updated old check form tests with new feature (#337)

admin/test/features/breadcrumbs.feature

@@ -3,14 +3,12 @@ Feature:
   I want to ensure that the system displays
   the navigation path as breadcrumb
 
-  @wip @fix-in-17402
   Scenario: Verify breadcrumb on manage check forms
-    Given I am logged in
-    And I am on the profile page
-    When I choose to manage check forms
-    Then I should see the breadcrumb as "Home > Manage check forms"
+    Given I have signed in with test-developer
+    And I am on the Upload and View forms page
+    Then I should see the breadcrumb as "Home > Upload and view forms"
     And I click the Home link on breadcrumb
-    Then I should be taken to the school landing page
+    Then I should be taken to the Test Developer homepage
 
   Scenario: Verify breadcrumb on add pupil page
     Given I am logged in
@@ -19,11 +17,10 @@ Feature:
     And I click the Home link on breadcrumb
     Then I should be taken to the school landing page
 
-  @wip
-  Scenario: Verify breadcrumb on Manage pupil page
-    Given I am logged in
-    And I click Manage pupil link
-    Then I should see the breadcrumb as "Home > Manage pupils"
+  Scenario: Verify breadcrumb on Generate Pin page
+    Given I have signed in with teacher1
+    And I navigate to generate pupil pins page
+    Then I should see the breadcrumb as "Home > Generate pupil PINs"
     And I click the Home link on breadcrumb
     Then I should be taken to the school landing page
 

admin/test/features/phase_banner.feature

@@ -42,9 +42,8 @@ Feature:
     Then I should see that we are in the beta development phase on the upload_and_view_forms page
     And I should see a new tab open when i want to provide feedback link from the upload_and_view_forms page
 
-  @wip @fix-in-17402
   Scenario: Development phase and the feedback link are displayed at the top of the view form page
-    Given I am logged in
+    Given I have signed in with test-developer
     When I have uploaded a check form
     And I choose to preview the check form questions
     Then I should see that we are in the beta development phase on the view_form page

admin/test/features/unauthorized_login.feature

@@ -6,12 +6,11 @@ Feature:
     When I try to view the admin page
     Then I should be shown the access unauthorized page
 
-  Scenario: Service managers can only access pages their roles apply to
+  Scenario: Test Developers can only access pages their roles apply to
     Given I have logged in with test-developer
     When I try to view the school landing page
     Then I should be shown the access unauthorized page
 
-  @wip @fix-in-17402
   Scenario: Access unauthorized page offers link to return to the school landing page
     Given I am on the unauthorized access page as a teacher
     When I decide to return to the homepage