Feature/65543 upgrade eslint to v9 #2975
Conversation
GuyHarwood
commented
Nov 15, 2024
•
GuyHarwood
commented
- upgrade eslint from 8 > 9
- remove standard
- remove deprecated plugins
|
closing until all lint issues fixed to avoid pointless CI work |
|
core linter rules passing |
|
exploring prettier...
produces 501~ file changes on just the admin app. will leave for now, pending discussion with wider team. |
GuyHarwood
added
the
CI Enabled
There was a problem hiding this comment.
👍 Fantastic work! Adding comments.
You might want to consider whether we want the additional testing burden of modernising (var => consts) the frontend code. This code might be minified, but it is not transpiled, and is delivered as-is which means these changes could affect anyone still using IE11/10 or Safari 10 (or earlier).
tslib/src/azure/app-insights.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import config from '../config' | |||
| import { isNil } from 'ramda' | |||
| const appInsights = require('applicationinsights') | |||
| import * as appInsights from 'applicationinsights' | |||
There was a problem hiding this comment.
Alarm bells are ringing here. Please do test this. Application Insights is very sensitive to ejs / cjs differences and although we are writing typescript esm, we are compiling to cjs to be run on node.
tslib/src/caching/redis-service.ts
Outdated
| @@ -40,7 +40,7 @@ export interface IRedisService { | |||
| * @param {Array<string>} keys an array of keys to invalidate | |||
| * @returns {Promise<Array<[error: Error | null, result: unknown]> | null | undefined>} | |||
There was a problem hiding this comment.
The jsdoc is out of date now the call sig has changed. Please consider either updating or deleting the jsdoc.
| @@ -25,7 +25,7 @@ export interface IRedisService { | |||
| * @param {Array<string>} keys an array of keys to invalidate | |||
| * @returns {Promise<void>} | |||
There was a problem hiding this comment.
The jsdoc type and the typescript types are misaligned. You can probably delete the jsdoc for *.ts files.
…DEVOPS/MTC into feature/65543-upgrade-eslint-v9
|
@jon-shipley based on our SPA browser policy and the govuk guidance we are ok to update the browser JS... for...of browser compatibility is OK - https://caniuse.com/?search=for...of |
