Feature/65678 upgrade angular #3006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably shoul not be needed as it appears to only be needed to assist in a unit test, however the change is harmless.
Prep for angular 16 upgrade
which required v5 typescript
* remove core-js polyfill library (unused) * address compilation warnings
…EAGILEDEVOPS/MTC into feature/65678-upgrade-angular
jon-shipley
added
the
CI Enabled
- parity across solution - prep for angular 17
* typscript 5.2 * zone.js 0.14
- typescript 5.5 - new build system
- had been changed to 'dist/browser' by the new angular build system
- remove browser installs - build the spa
- needed for frontend tests / spa tests
- should not have been checked in
jon-shipley
force-pushed
the
feature/65678-upgrade-angular
branch
from
d779e01 to
930e8ff
Compare
- allows karma build to be done using the new application builder, which works. - some deprecations raised as warnings - this is the result of the automated angular migration plus manual eslint updates - some lint errors
- these were automatically added during the migration - pre v19 components (which these are) default to false
jon-shipley
added
CI Enabled
GuyHarwood
approved these changes
Jan 16, 2025
pupil-spa/src/.sass-cache/03391ceb0ad1eda7f6cc1f1300737f67d71a4946/_alpha-beta.scssc
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade pupil SPA
ng testwhich is now also using esbuild