Prevent timeout when waiting for ACK #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and speed up execution of all commands that only have ACK and no other reply because the 500 ms default timeout is not waited for anymore. new waitSending(): private adaption of waitAvailable() that waits only for the ACK packet and not one that sets _isAvailable which usually does not happen and causes unnecessary waiting and timeout signalling; sendStack(): use waitSending() instead of waitAvailable() because we only need the _isSending flag to drop;
|
Is this of interest? @qsjhyy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and speed up execution of all commands that only have ACK and no other reply because the 500 ms default timeout is not waited for anymore.
new waitSending():
private adaption of waitAvailable() that waits only for the ACK
packet and not one that sets _isAvailable which usually does not
happen and causes unnecessary waiting and timeout signalling;
sendStack():
use waitSending() instead of waitAvailable() because we only need
the _isSending flag to drop;