fixed computed not returning in all cases

DH-Center-Tuebingen · Oct 17, 2023 · c1820df · c1820df
1 parent c1ebd3b
commit c1820df
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/resources/js/components/attribute/Iconclass.vue b/resources/js/components/attribute/Iconclass.vue
@@ -158,11 +158,13 @@
                     if(state.infoLoaded) {
                         return state.info.kw[state.language] ? state.info.kw[state.language] : state.info.kw['en'];
                     }
+                    return []
                 }),
                 text: computed(_ => {
                     if(state.infoLoaded) {
                         return state.info.txt[state.language] ? state.info.txt[state.language] : state.info.txt['en'];
                     }
+                    return ''
                 }),
             });
             const v = reactive({

diff --git a/resources/js/components/attribute/Rism.vue b/resources/js/components/attribute/Rism.vue
@@ -173,6 +173,7 @@
                         }
                         return t('main.entity.attributes.rism.doesnt_exist');
                     }
+                    return ''
                 }),
             });
             const v = reactive({

diff --git a/resources/js/components/modals/attribute/Edit.vue b/resources/js/components/modals/attribute/Edit.vue
@@ -365,8 +365,8 @@
                 }),
                 operatorList: computed(_ => {
                     if(!state.attributeSelected) return [];
-
-                    switch(state.dependency.attribute.datatype) {
+                    const datatype = state.dependency.attribute.datatype
+                    switch(datatype) {
                         case 'epoch':
                         case 'timeperiod':
                         case 'dimension':
@@ -419,6 +419,8 @@
                                         return false;
                                 }
                             });
+                        default:
+                            throw new Error(`Unsupported datatype ${datatype}`);
                     }
                 }),
                 inputType: computed(_ => {

diff --git a/resources/js/components/notification/NotificationBody.vue b/resources/js/components/notification/NotificationBody.vue
@@ -288,6 +288,8 @@
                             return 'comment';
                         case 'App\\Notifications\\EntityUpdated':
                             return 'entity';
+                        default:
+                            throw new Error(`Unknown notification type: ${type}`)
                     }
                 }),
                 canReply: computed(_ => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -173,6 +173,7 @@ @@
                             }
                             return t('main.entity.attributes.rism.doesnt_exist');
                         }
+                        return ''
                     }),
                 });
                 const v = reactive({
@@ Expand Down @@