-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor: 캘린더 사용성 개선 #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor: 캘린더 사용성 개선 #186
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e37a989
♻️ Refactor: 캘린더 칩 사이즈 변경
dogmania e6013f1
♻️ Refactor: Chip 사이 간격 수정
dogmania c5d9877
✨ Feat: pad 없는 날짜 포맷팅 메서드 추가
dogmania e906211
♻️ Refactor: 캘린더 바텀시트 날짜 렌더링 형식 변경
dogmania 3285511
♻️ Refactor: GNB 아이콘 변경 및 간격 수정
dogmania 0c546a1
🍱 Chore: String 리소스 추가
dogmania b069b50
✨ Feat: TodayFAB 컴포넌트 구현
dogmania a779af4
✨ Feat: 현재 날짜와 다른 달로 넘겼을 때 TodayFAB 렌더링 및 클릭 시 오늘 날짜로 복귀
dogmania 80243e7
♻️ Refactor: ktlint 적용
dogmania abf5252
🍱 Chore: String 리소스 추가
dogmania 80ed51d
✨ Feat: preparationNote 상태 변수 추가
dogmania 88e66eb
✨ Feat: 준비물 정보 렌더링
dogmania c59b06b
🍱 Chore: String 리소스 추가
dogmania 2c8e590
✨ Feat: 칩 최대 개수 초과시 남은 개수 렌더링
dogmania 2258b23
✨ Feat: hasActivieAlarm 프로퍼티 추가
dogmania e86ae27
✨ Feat: isRepeat, hasActiveAlarm 상태 저장 로직 추가
dogmania 0b53a82
✨ Feat: isRepeat, hasActiveAlarm에 따른 색상 변경 로직 구현
dogmania f417601
⬆️ Upgrade: 버전 업데이트
dogmania a19b659
✨Feat: System Trace expect 정의
dogmania 6468261
✨ Feat: System Trace 로깅 Modifier 확장 메서드 구현
dogmania ce15f5c
✨ Feat: system trace 기록 메서드 호출
dogmania e6c7c40
🍱 Chore: BodySmallM 폰트 스타일 추가
dogmania f305161
✨ Feat: 반복, 비반복, off 일정 칩 색상 및 border 적용
dogmania 6d83125
♻️ Refactor: 집 주소와 달라지면 집에서 출발해요 체크박스 해제
dogmania f12b8b5
♻️ Refactor: 준비물 텍스트 오버플로우 처리
dogmania File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+656 Bytes
(130%)
core/design-system/src/commonMain/composeResources/drawable/ic_home_selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+820 Bytes
(130%)
core/design-system/src/commonMain/composeResources/drawable/ic_home_unselected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
core/ui/src/androidMain/kotlin/com/ondot/ui/util/SystemTrace.android.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package com.ondot.ui.util | ||
|
|
||
| import android.os.Trace | ||
| import com.dh.core.ui.BuildConfig | ||
|
|
||
| actual inline fun <T> systemTrace( | ||
| name: String, | ||
| block: () -> T, | ||
| ): T { | ||
| if (!BuildConfig.DEBUG) { | ||
| return block() | ||
| } | ||
|
|
||
| Trace.beginSection(name) | ||
| return try { | ||
| block() | ||
| } finally { | ||
| Trace.endSection() | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
core/ui/src/commonMain/kotlin/com/ondot/ui/util/SystemTrace.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.ondot.ui.util | ||
|
|
||
| expect inline fun <T> systemTrace( | ||
| name: String, | ||
| block: () -> T, | ||
| ): T |
34 changes: 34 additions & 0 deletions
34
core/ui/src/commonMain/kotlin/com/ondot/ui/util/TraceLayoutModifier.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package com.ondot.ui.util | ||
|
|
||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.draw.drawWithContent | ||
| import androidx.compose.ui.layout.layout | ||
|
|
||
| /** | ||
| * Compose의 Layout 단계에서 | ||
| * measure(크기 계산), layout(위치 계산) 각각의 시간이 얼마나 걸리는지를 System Trace에 기록하는 함수 | ||
| * */ | ||
| fun Modifier.traceLayout(name: String): Modifier = | ||
| layout { measurable, constraints -> | ||
| val placeable = | ||
| systemTrace("measure:$name") { | ||
| measurable.measure(constraints) | ||
| } | ||
|
|
||
| systemTrace("layout:$name") { | ||
| layout(placeable.width, placeable.height) { | ||
| placeable.placeRelative(0, 0) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Compose의 Draw 단계에서 | ||
| * draw(그리기) 시간이 얼마나 걸리는지를 System Trace에 기록하는 함수 | ||
| * */ | ||
| fun Modifier.traceDraw(name: String): Modifier = | ||
| drawWithContent { | ||
| systemTrace("draw:$name") { | ||
| drawContent() | ||
| } | ||
| } | ||
6 changes: 6 additions & 0 deletions
6
core/ui/src/iosMain/kotlin/com/ondot/ui/util/SystemTrace.ios.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.ondot.ui.util | ||
|
|
||
| actual inline fun <T> systemTrace( | ||
| name: String, | ||
| block: () -> T, | ||
| ): T = block() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,4 +20,5 @@ enum class OnDotTextStyle { | |
| BodySmallR1, | ||
| BodySmallR2, | ||
| BodySmallR3, | ||
| BodySmallM, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.