Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b76b0e8
✨ Feat: 편집 화면 전용 PlacePickerRoute 구현
dogmania Jun 6, 2026
fde0dec
♻️ Refactor: RouteInput 변경 시 Type도 함께 전달하도록 개선
dogmania Jun 6, 2026
d7641a7
✨ Feat: 편집 화면 -> PlacePicker, RouteLoading 네비게이션 GA 이벤트 기록
dogmania Jun 6, 2026
cc9af0c
✨ Feat: 편집 화면 RouteLoading, PlacePicker NavRoutes 정의
dogmania Jun 6, 2026
b2d551c
✨ Feat: transportType 필드 추가
dogmania Jun 6, 2026
9cdbd1c
✨ Feat: 도착지 텍스트 필드 활성화 이벤트 추가
dogmania Jun 6, 2026
322be64
✨ Feat: PlacePicker, RouteLoading 네비게이션 로직 구현
dogmania Jun 6, 2026
01779ae
✨ Feat: PlacePickerState 상태 추가
dogmania Jun 6, 2026
f168718
✨ Feat: 장소 및 히스토리 상태 처리 로직 구현
dogmania Jun 6, 2026
b37bb34
✨ Feat: 수정 화면 알람 재계산 기능 구현
dogmania Jun 6, 2026
2dd8cab
♻️ Refactor: 약속 날짜 수정의 경우 기존 날짜와 delta 계산 후 알람 날짜에 반영
dogmania Jun 6, 2026
4f0033b
♻️ Refactor: autoNavigate 옵션 추가
dogmania Jun 6, 2026
0ee8006
✨ Feat: 편집 화면 RouteLoadingRoute 추가
dogmania Jun 6, 2026
d3ffdb2
♻️ Refactor: preparePlacePicker 메서드를 활용해 이전 수정값이 유지되는 것을 방지
dogmania Jun 6, 2026
bf5bb68
✨ Feat: 알람 계산 중 여부를 나타내는 플래그 변수 추가
dogmania Jun 6, 2026
6a441cf
✨ Feat: 편집 화면 RouteLoading 네비게이션 구현
dogmania Jun 6, 2026
c7ebbb7
✨ Feat: Preview 라이브러리 추가
dogmania Jun 6, 2026
07a12c5
🍱 Chore: OnDotText Preview 구현
dogmania Jun 6, 2026
a34f451
✨ Feat: Preview 라이브러리 적용
dogmania Jun 6, 2026
91d54be
✨ Feat: 일정 생성 전용 알람 시간 수정 바텀시트 구현
dogmania Jun 6, 2026
97dc8d8
✨ Feat: 현재 변경 중인 알람 타입 상태 변수 추가
dogmania Jun 6, 2026
932183a
✨ Feat: 현재 변경 중인 알람 타입 상태 변수 추가
dogmania Jun 6, 2026
183fa7a
♻️ Refactor: 레거시 화면 대응
dogmania Jun 6, 2026
5ce23db
✨ Feat: 바텀시트 활성화, 알람 타입 설정 Intent 정의
dogmania Jun 6, 2026
58e4a92
✨ Feat: 알람 시간 업데이트 상태 처리 로직 구현
dogmania Jun 6, 2026
2211cd9
✨ Feat: 준비, 출발 알람 수정 바텀시트 렌더링 로직 구현
dogmania Jun 6, 2026
0451a12
♻️ Refactor: lint 적용
dogmania Jun 6, 2026
8b76e42
⬆️ Upgrade: 버전 코드 업데이트
dogmania Jun 6, 2026
124859b
♻️ Refactor: alarmId 유효성 검증 로직 추가
dogmania Jun 9, 2026
d234e5a
♻️ Refactor: 재계산된 alarmId를 기존 alarmId로 변경하는 로직 추가
dogmania Jun 9, 2026
fef20be
⬆️ Upgrade: 버전 코드 업데이트
dogmania Jun 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ class ComposeMultiplatformConventionPlugin: Plugin<Project> {

addComposeCommonDependencies(libs)

dependencies.add(
"debugImplementation",
libs.findLibrary("compose-uiTooling").get(),
)

// TODO(이후에 feature 모듈로 분리되어야 함)
extensions.configure<KotlinMultiplatformExtension> {
Expand Down Expand Up @@ -106,4 +110,4 @@ class ComposeMultiplatformConventionPlugin: Plugin<Project> {
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@ fun Project.addComposeCommonDependencies(libs: VersionCatalog) {
implementation(libs.findLibrary("compose-foundation").get())
implementation(libs.findLibrary("compose-ui").get())
implementation(libs.findLibrary("compose-material3").get())
implementation(libs.findLibrary("compose-components-ui-tooling-preview").get())
implementation(libs.findLibrary("compose-components-resources").get())
}
}
}

fun Project.applyOnce(id: String) {
if (!plugins.hasPlugin(id)) pluginManager.apply(id)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ fun RouteInputSection(
departureFocusRequester: FocusRequester = FocusRequester(),
arrivalFocusRequester: FocusRequester = FocusRequester(),
onRouteInputChanged: (String) -> Unit = {},
onRouteInputChangedByType: (RouterType, String) -> Unit = { _, value -> onRouteInputChanged(value) },
onRouteInputFocused: (RouterType) -> Unit = {},
) {
Column(
Expand All @@ -67,7 +68,7 @@ fun RouteInputSection(
input = departurePlaceInput,
readOnly = readOnly,
focusRequester = departureFocusRequester,
onValueChanged = onRouteInputChanged,
onValueChanged = { onRouteInputChangedByType(RouterType.Departure, it) },
onRouteInputFocused = onRouteInputFocused,
)

Expand All @@ -82,7 +83,7 @@ fun RouteInputSection(
input = arrivalPlaceInput,
readOnly = readOnly,
focusRequester = arrivalFocusRequester,
onValueChanged = onRouteInputChanged,
onValueChanged = { onRouteInputChangedByType(RouterType.Arrival, it) },
onRouteInputFocused = onRouteInputFocused,
)
}
Expand Down Expand Up @@ -140,6 +141,7 @@ fun RouteInputTextField(
}
},
readOnly = readOnly,
enabled = !readOnly,
singleLine = true,
textStyle = OnDotTypo().bodyLargeR1.copy(color = Gray0),
cursorBrush = SolidColor(Gray0),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package com.ondot.designsystem.preview

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import com.dh.ondot.presentation.ui.theme.OnDotTheme
import com.ondot.designsystem.components.OnDotText
import com.ondot.designsystem.theme.OnDotColor.Gray0
import com.ondot.designsystem.theme.OnDotColor.Gray900
import com.ondot.domain.model.enums.OnDotTextStyle
import org.jetbrains.compose.ui.tooling.preview.Preview

@Preview
@Composable
private fun OnDotTextPreview() {
OnDotTheme {
Box(
modifier =
Modifier
.fillMaxSize()
.background(Gray0)
.padding(16.dp),
contentAlignment = Alignment.Center,
) {
OnDotText(
text = "OnDot Preview",
style = OnDotTextStyle.BodyLargeSB,
color = Gray900,
)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ private fun String.toScreenViewEventName(): String =

// 패턴 라우트는 ROUTE로 매칭
NavRoutes.EditSchedule.ROUTE -> "screen_view_edit_schedule"
NavRoutes.EditPlacePicker.route -> "screen_view_edit_place_picker"
NavRoutes.EditRouteLoading.route -> "screen_view_edit_route_loading"
NavRoutes.PreparationAlarm.ROUTE -> "screen_view_preparation_alarm"
NavRoutes.DepartureAlarm.ROUTE -> "screen_view_departure_alarm"
NavRoutes.ServiceTerms.ROUTE -> "screen_view_service_terms"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ sealed class NavRoutes(
}
}

data object EditPlacePicker : NavRoutes("editPlacePicker")

data object EditRouteLoading : NavRoutes("editRouteLoading")

// DeleteAccount
data object DeleteAccountGraph : NavRoutes("deleteAccountGraph")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import ondot.core.design_system.generated.resources.Res
@Composable
fun RouteLoadingScreen(
label: String = ROUTE_CALCULATE_LABEL,
autoNavigate: Boolean = true,
navigateToNext: () -> Unit,
) {
val composition by rememberLottieComposition {
Expand All @@ -39,9 +40,11 @@ fun RouteLoadingScreen(
iterations = Compottie.IterateForever,
)

LaunchedEffect(Unit) {
delay(2000L)
navigateToNext()
LaunchedEffect(autoNavigate) {
if (autoNavigate) {
delay(2000L)
navigateToNext()
}
}

Box(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ fun PlacePickerScreen(
departureFocusRequester: FocusRequester = remember { FocusRequester() },
arrivalFocusRequester: FocusRequester = remember { FocusRequester() },
onRouteInputChanged: (String) -> Unit,
onRouteInputChangedByType: (RouterType, String) -> Unit = { _, value -> onRouteInputChanged(value) },
onRouteInputFocused: (RouterType) -> Unit,
onPlaceSelected: (AddressInfo) -> Unit,
onHistorySelected: (PlaceHistory) -> Unit,
Expand Down Expand Up @@ -137,6 +138,7 @@ fun PlacePickerScreen(
departureFocusRequester = departureFocusRequester,
arrivalFocusRequester = arrivalFocusRequester,
onRouteInputChanged = onRouteInputChanged,
onRouteInputChangedByType = onRouteInputChangedByType,
onRouteInputFocused = onRouteInputFocused,
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ class DefaultScheduleAlarmManager(
val mapProvider = currentMapProvider()
val dedupedAlarmInfos =
dedupeAlarmInfos(
schedules.flatMap { schedule -> enabledAlarmInfos(schedule) },
validAlarmInfos(
infos = schedules.flatMap { schedule -> enabledAlarmInfos(schedule) },
throwOnInvalid = false,
),
)
val currentAlarmIds = dedupedAlarmInfos.map { it.alarm.alarmId }.toSet()

Expand Down Expand Up @@ -59,7 +62,13 @@ class DefaultScheduleAlarmManager(

override suspend fun schedule(schedule: Schedule) {
val mapProvider = currentMapProvider()
val dedupedAlarmInfos = dedupeAlarmInfos(enabledAlarmInfos(schedule))
val dedupedAlarmInfos =
dedupeAlarmInfos(
validAlarmInfos(
infos = enabledAlarmInfos(schedule),
throwOnInvalid = true,
),
)

scheduleInfos(
infos = dedupedAlarmInfos,
Expand Down Expand Up @@ -189,6 +198,31 @@ class DefaultScheduleAlarmManager(

private suspend fun currentMapProvider(): MapProvider = memberRepository.getLocalMapProvider().first()

private fun validAlarmInfos(
infos: List<AlarmRingInfo>,
throwOnInvalid: Boolean,
): List<AlarmRingInfo> {
val invalidInfos = infos.filter { it.alarm.alarmId <= 0 }

if (invalidInfos.isNotEmpty()) {
val message =
invalidInfos.joinToString(
prefix = "invalid alarmId detected: ",
separator = ", ",
) { info ->
"scheduleId=${info.scheduleId}, alarmId=${info.alarm.alarmId}, type=${info.alarmType}"
}

if (throwOnInvalid) {
throw IllegalStateException(message)
} else {
logger.e { message }
}
}

return infos.filter { it.alarm.alarmId > 0 }
}

private fun enabledAlarmIds(schedule: Schedule): List<Long> =
buildList {
if (schedule.preparationAlarm.enabled) add(schedule.preparationAlarm.alarmId)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ data class ScheduleAlarmRequest(
val startLatitude: Double,
val endLongitude: Double,
val endLatitude: Double,
val transportType: String,
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
package com.ondot.edit

import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.ui.focus.FocusRequester
import androidx.compose.ui.platform.LocalFocusManager
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.ondot.platform.util.BackPressHandler
import com.ondot.ui.screen.placepicker.PlacePickerScreen
import org.koin.compose.viewmodel.koinViewModel

@Composable
fun EditPlacePickerRoute(
viewModel: EditScheduleViewModel = koinViewModel(),
popScreen: () -> Unit,
navigateToRouteLoading: () -> Unit,
) {
val uiState by viewModel.uiState.collectAsStateWithLifecycle()
val departureFocusRequester = remember { FocusRequester() }
val arrivalFocusRequester = remember { FocusRequester() }
val focusManager = LocalFocusManager.current

LaunchedEffect(Unit) {
viewModel.preparePlacePicker()

if (uiState.placePickerState.homeAddress.title
.isBlank() &&
!uiState.isHomeAddressInitialized
) {
viewModel.fetchHomeAddress()
}
viewModel.fetchPlaceHistory()
}

LaunchedEffect(viewModel.eventFlow) {
viewModel.eventFlow.collect { event ->
when (event) {
EditScheduleEvent.RequestArrivalFocus -> arrivalFocusRequester.requestFocus()
else -> Unit
}
}
}

LaunchedEffect(uiState.isInitialPlacePicker) {
if (uiState.isInitialPlacePicker) {
departureFocusRequester.requestFocus()
viewModel.setInitialPlacePicker(false)
}
}

BackPressHandler(onBack = popScreen)

PlacePickerScreen(
state = uiState.placePickerState,
buttonEnabled = uiState.isPlacePickerButtonEnabled,
departureFocusRequester = departureFocusRequester,
arrivalFocusRequester = arrivalFocusRequester,
onRouteInputChanged = viewModel::updateRouteInput,
onRouteInputChangedByType = viewModel::updateRouteInput,
onRouteInputFocused = viewModel::setFocusedRouterType,
onPlaceSelected = {
viewModel.selectPlace(it)
focusManager.clearFocus()
},
onHistorySelected = {
viewModel.selectHistory(it)
focusManager.clearFocus()
},
onDeleteHistory = viewModel::deletePlaceHistory,
onToggleCheckBox = viewModel::toggleHomeDeparture,
onTransportTypeChanged = viewModel::updateTransportType,
onNext = {
if (viewModel.applyRouteChangesAndFetchAlarms()) {
navigateToRouteLoading()
} else {
popScreen()
}
},
popScreen = popScreen,
)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package com.ondot.edit

import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.ondot.ui.screen.loading.RouteLoadingScreen
import org.koin.compose.viewmodel.koinViewModel

@Composable
fun EditRouteLoadingRoute(
viewModel: EditScheduleViewModel = koinViewModel(),
navigateToEdit: () -> Unit,
) {
val uiState by viewModel.uiState.collectAsStateWithLifecycle()

LaunchedEffect(uiState.isAlarmRecalculating) {
if (!uiState.isAlarmRecalculating) {
navigateToEdit()
}
}
Comment thread
dogmania marked this conversation as resolved.

RouteLoadingScreen(
autoNavigate = false,
navigateToNext = {},
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ import com.ondot.ui.base.Event

sealed class EditScheduleEvent : Event {
data object NavigateBack : EditScheduleEvent()

data object RequestArrivalFocus : EditScheduleEvent()
}
Loading
Loading