feat(api): collect AI shown/hidden flag for cases and fix assign cases shell script #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangsonww
added
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces tracking of whether an AI-generated score was shown to users and refines the case-assignment shell script, alongside applying Black formatting rules across the codebase.
- Add
ai_score_shownhandling in the answer service and model - Enhance
generate_config.shfor interactive password entry and per-user loops - Update Black configuration and reformat imports/signatures project-wide
Reviewed Changes
Copilot reviewed 20 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/configration/utils/answer_config_validations/multiple_choice.py | Reformatted import block |
| src/configration/service/answer_config_service.py | Reformatted import block |
| src/configration/controller/answer_config_controller.py | Reformatted _needs_attention_check signature |
| src/common/service/email_service.py | Reformatted import block |
| src/common/exception/exception_handlers.py | Reformatted import block |
| src/common/exception/BusinessException.py | Reformatted enum formatting |
| src/cases/service/case_service.py | Reformatted chained calls and imports |
| src/cases/repository/visit_occurrence_repository.py | Reformatted import |
| src/cases/repository/measurement_repository.py | Reformatted import |
| src/cases/controller/case_controller.py | Reformatted imports |
| src/answer/service/answer_service.py | Added ai_shown flag extraction and passing to repository |
| src/answer/model/answer.py | Added ai_score_shown column to Answer model |
| src/answer/controller/answer_controller.py | Reformatted imports |
| src/analytics/service/analytics_service.py | Reformatted record_metrics signature |
| src/analytics/repository/analytics_repository.py | Cleaned up extra blank line |
| src/analytics/model/analytics.py | Reformatted timestamp columns |
| src/analytics/controller/analytics_controller.py | Reformatted imports and error-message punctuation |
| script/assign_cases/generate_config.sh | Switched to bash, interactive password prompt, per-user loop |
| pyproject.toml | Set Black line-length and target-version |
| README.md | Added Black and migration guidance |
Comments suppressed due to low confidence (1)
src/answer/service/answer_service.py:31
- The new
ai_score_shownbehavior isn’t covered by existing tests. Consider adding unit tests to verify that this flag is correctly extracted, stored, and retrieved.
ai_shown = data.get("aiScoreShown", False)
|
|
||
| configuration = self.configuration_repository.get_configuration_by_id(task_id) | ||
|
|
||
| if not configuration or configuration.user_email != user_eamil: |
There was a problem hiding this comment.
There's a typo in the variable name user_eamil. It should be user_email to match the existing variable.
Suggested change
| if not configuration or configuration.user_email != user_eamil: | |
| if not configuration or configuration.user_email != user_email: |
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env sh | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
[nitpick] Consider adding set -euo pipefail immediately after the shebang to ensure the script exits on errors, treats unset variables as errors, and fails on pipeline errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR collects AI flag for each case and assign cases to all participants in the study. It also fixes
Blackformatter rules and reformatted all Python files in the project.Pre-merge author checklist