Skip to content

fix: properly extract leaf texts from PHYSICAL EXAMINATION path_config #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karokojnr merged 1 commit into from
Nov 19, 2025
Merged

fix: properly extract leaf texts from PHYSICAL EXAMINATION path_config #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/cases/service/case_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,24 @@ def get_nodes_of_measurement(self, case_id, title_config):
children_measurements, lambda m: m.measurement_concept_id
)
for concept_id, rows in measurements_by_concept.items():
label = self.get_concept_name(concept_id)
# Normalize BMI label to "range" at build time for consistent UI
if label == "BMI (body mass index) centile":
label = "BMI (body mass index) range"
parent_node.add_node(
TreeNode(
self.get_concept_name(concept_id),
label,
get_value_of_rows(rows, self.get_value_of_measurement),
)
)
if parent_node.values:
data.append(parent_node)
# Safety: if already built under Body measure as child nodes, normalize too
for node in data:
if node.key == "Body measure" and node.values and isinstance(node.values[0], TreeNode):
for child in node.values:
if child.key == "BMI (body mass index) centile":
child.key = "BMI (body mass index) range"
return data

def get_value_of_measurement(self, measurement) -> str | None:
Expand Down Expand Up @@ -381,10 +391,12 @@ def get_case_review(self, case_config_id): # pragma: no cover
)

# --- 4b) Filter and rename PHYSICAL EXAMINATION based on path_config ---
# Build a set of all PHYSICAL EXAMINATION items that should be kept
# Build a set of all PHYSICAL EXAMINATION leaf texts that should be kept
phys_exam_keep = set()
has_phys_exam_config = False
for pk, entries in parent_to_entries.items():
if pk.startswith("PHYSICAL EXAMINATION."):
has_phys_exam_config = True
# Extract leaf texts (these are the actual child.key values to keep)
for e in entries:
phys_exam_keep.add(e["leaf"])
Expand All @@ -394,8 +406,8 @@ def get_case_review(self, case_config_id): # pragma: no cover
if top.key != "PHYSICAL EXAMINATION":
continue

# If phys_exam_keep is not empty, filter children
if phys_exam_keep:
# If we have PHYSICAL EXAMINATION entries in path_config, filter
if has_phys_exam_config:
# Keep only children whose key is in the keep set
filtered_children = []
for child in top.values:
Expand All @@ -406,7 +418,7 @@ def get_case_review(self, case_config_id): # pragma: no cover
filtered_children.append(child)
top.values = filtered_children
else:
# No filtering needed, just rename BMI if present
# No PHYSICAL EXAMINATION in path_config, just rename BMI if present
for child in top.values:
if child.key == "BMI (body mass index) centile":
child.key = "BMI (body mass index) range"
Expand Down
Loading