feat(api): emit exactly the important infos needed #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangsonww
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the case review logic to emit only the important information needed. Key changes include simplified docstring instructions, updated handling for CSV-provided literal scores (now potentially multiple) with computed min/max values, and adjustments to the fallback logic for old CRC toggles.
Comments suppressed due to low confidence (2)
src/cases/service/case_service.py:367
- Consider adding a comment clarifying the expected CSV literal format (e.g., 'Colorectal Cancer Score: ') to aid future maintenance and ensure numeric conversion assumptions are documented.
parts = leaf.split(":")
src/cases/service/case_service.py:375
- [nitpick] Add a comment to explain why the first literal score is selected as the 'predicted' score, providing context for future reviewers.
predicted_leaf = csv_crc_score_leaves[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.