-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/react ts client preview #194
Conversation
Probably #140 is fixed(currently you can only slide, and not use an input for those min/max values - unsure if this is an issue. The precision of the slider for singleband values is There are discussions going around #91 about having a client library that wraps TC with a Map provider - probably through deck.gl. Stay tuned As about #135, hmm interesting feature, sparks my interest so I might look into it, but as a separate PR. |
OK. I personally prefer entering values to sliding, but your call if you want to support that. #140 was not about this, though. The bug arose when a raster had a constant value, e.g. all 0. Then, the slider would break. So you should probably test this case to make sure it's fixed. |
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 45 45
Lines 2200 2200
Branches 273 273
=======================================
Hits 2164 2164
Misses 20 20
Partials 16 16
Continue to review full report at Codecov.
|
Thanks for the implementation, it sure looks more professional now. I just tried it, and I do have some comments:
No one has asked for my review, so you can do with this feedback whatever you want. |
Thanks for the ex post facto review, @dionhaefner. 😄 Thought it was nice to push the remake out there, great you are already picking up the revision on another PR, @bertearazvan. |
This PR aims to rewrite the Terracotta preview app using React and Typescript based on the create-react-app boilerplate.
Close #195
Close #140