-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue104; get valid key value combinations #234
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 98.57% 98.58%
=======================================
Files 45 47 +2
Lines 2251 2332 +81
Branches 287 303 +16
=======================================
+ Hits 2219 2299 +80
Misses 18 18
- Partials 14 15 +1
Continue to review full report at Codecov.
|
Thanks for the implementation, looks pretty good. But I'm a bit hesitant to support this without a clear use case. Adding another SQL command complicates the drivers even more, so this looks a bit like feature creep to me. What do you think @j08lue? Have you ever missed this feature? |
I am not sure. Not me, personally. Maybe @bertearazvan can comment whether we are doing this in any frontend:
If we do that anywhere, e.g. in order to create menus for selecting from them or so, this endpoint could replace that. But the result can be misleading - these are the unique values, but you do not know whether any combination of them exists until you check (e.g. |
We have the following use cases where this can be useful:
I think we can benefit from this in the future when dealing with a large number of datasets - @j08lue like LBST, maybe? |
Make it possible to discover which key values exists -- optionally after filtering for specific key values.
This closes #104.
Can be called as
to get all possible values for each key,
or
to get all valid values for each key, when one or more keys are set,
or
where, in the last query, notice that the multi-querying syntax introduced from issue #33 is supported.