Update docker image to python 3.12 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Semi-related: Could be nice to build this image on CI and push to DockerHub on release. WDYT? |
|
@dionhaefner yes good idea |
Make image versatile to run as a client or as API
charalamm
force-pushed
the
update-docker
branch
from
fb0cd1b to
9d6ca0c
Compare
|
@dionhaefner Unfortunately we dont have dockerhub account and it seems it will take some time to create one. I will add the CI once we have it. I am undrafting so you can merge if it looks good to you too |
|
Oh I forgot that DockerHub isn't free anymore. Let's merge this first, but testing the image build on CI could be valuable too, to ensure nothing breaks. I'll add an issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.