closing JosiahParry#55

Merge branch 'rsbivand-main' into main
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

DESCRIPTION

@@ -2,9 +2,9 @@ Package: sfdep
 Title: Spatial Dependence for Simple Features
 Version: 0.2.4.9000
 Authors@R: c(
-    person("Josiah", "Parry", , "[email protected]", role = c("aut"),
+    person("Josiah", "Parry", email = "[email protected]", role = c("aut"),
            comment = c(ORCID = "0000-0001-9910-865X")),
-    person("Dexter", "Locke", 'H', "[email protected]", role = c("aut", "cre"),
+    person("Dexter", "Locke", email = "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2704-9720"))
   )
 Description: An interface to 'spdep' to integrate with 'sf' objects and the 'tidyverse'.
@@ -35,7 +35,7 @@ Suggests:
 Config/testthat/edition: 3
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 Imports: 
     sf,
     cli,

R/spacetime-methods.R

@@ -53,7 +53,7 @@ spt_update <- function(x, ...) {
 
 #' Cast between `spacetime` and `sf` classes
 #'
-#' @param x for [sfdep::st_as_sf()] a spacetime object. For [sfdep::as_spacetime()]
+#' @param x for [sf::st_as_sf()] a spacetime object. For [sfdep::as_spacetime()]
 #'   an sf object.
 #' @param ... arguments passed to merge.
 #' @export

R/utils-set-operations.R

@@ -23,6 +23,7 @@
 #' @export
 nb_union <- function(x, y) {
   res <- mapply(union, x, y, SIMPLIFY = FALSE)
+  res <- lapply(res, sort)
   res <- fill_missing_nb(res)
   class_modify(res, "nb")
 }
@@ -32,6 +33,7 @@ nb_union <- function(x, y) {
 #' @export
 nb_intersect <- function(x, y) {
   res <- mapply(intersect, x, y, SIMPLIFY = FALSE)
+  res <- lapply(res, sort)
   res <- fill_missing_nb(res)
   class_modify(res, "nb")
 }
@@ -40,6 +42,7 @@ nb_intersect <- function(x, y) {
 #' @export
 nb_setdiff <- function(x, y) {
   res <- mapply(setdiff, x, y, SIMPLIFY = FALSE)
+  res <- lapply(res, sort)
   res <- fill_missing_nb(res)
   class_modify(res, "nb")
 }