[8.0] Implementation of metadata methods into RucioFileCatalogClient #7383
Conversation
DIRACGridBot
added
the
alsoTargeting:integration
There was a problem hiding this comment.
This is a rather lightweight review since I don't have a working multi-VO Rucio server to see what the client actually does. Most of work is delegated to the server so it would be beyond the client review. I think one would need some basic unit tests of the client to follow the logic. This would be especially useful for set and delete methods where it is unclear what they are supposed to return.
| def getFileUserMetadata(self, path): | ||
| """Get the meta data attached to a file, but also to | ||
| all its parents | ||
| """ |
There was a problem hiding this comment.
Describe method arguments for all methods (and their return objects)
| self.client.set_dids_metadata_bulk(dids=dids, recursive=False) | ||
| except Exception as err: | ||
| return S_ERROR(str(err)) | ||
| return S_OK(resDict) |
There was a problem hiding this comment.
No. Will change it. Since we use a bulk method server side, the metadata will be either all registered or all failed
| if failedMeta: | ||
| metaExample = list(failedMeta)[0] | ||
| result = S_ERROR(f"Failed to remove {len(failedMeta)} metadata, e.g. {failedMeta[metaExample]}") | ||
| result["FailedMetadata"] = failedMeta |
There was a problem hiding this comment.
Shouldn't the key be "Failed" ?
result is never used. This is true for resDict as well.
There was a problem hiding this comment.
Yes, that's a mistake. It should be
return S_ERROR(f"Failed to remove {len(failedMeta)} metadata, e.g. {failedMeta[metaExample]}")
|
Any update here? Anything we could do to help? |
Closes #7382
BEGINRELEASENOTES
*Resources
NEW : Introduce a first implementation of metadata methods into RucioFileCatalogClient
ENDRELEASENOTES