Feature curved pyramids #1036
Open
Feature curved pyramids #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est-feature-curved-pyramids
jfussbro
changed the base branch from
main
to
feature-puma_patches_batch_processing_geometry3
…eature_curved_pyramids
Base automatically changed from
feature-puma_patches_batch_processing_geometry3
to
main
April 29, 2024 11:58
This was referenced Apr 29, 2024
sandro-elsweijer
requested changes
May 24, 2024
test/t8_geometry/t8_geometry_implementations/t8_gtest_geometry_cad.cxx
Outdated
Show resolved
Hide resolved
Comment on lines
+430
to
+446
| const double orthogonal_direction[8][5] | ||
| = { { ref_coords[2], 0, 0, 0, ref_coords[0] }, | ||
| { 0, ref_coords[2], 0, 0, (1 - ref_coords[0]) }, | ||
| { 0, 0, ref_coords[2], 0, ref_coords[1] }, | ||
| { 0, 0, 0, ref_coords[2], (1 - ref_coords[1]) }, | ||
| { (ref_coords[1] - ref_coords[2]), 0, (ref_coords[0] - ref_coords[2]), 0, 0 }, | ||
| { 0, (ref_coords[1] - ref_coords[2]), (1 - ref_coords[0]), 0, 0 }, | ||
| { 0, (1 - ref_coords[1]), 0, (1 - ref_coords[0]), 0 }, | ||
| { (1 - ref_coords[1]), 0, 0, (ref_coords[0] - ref_coords[2]), 0 } }; | ||
| const double max_orthogonal_direction[8][5] = { { ref_coords[1], 0, 0, 0, 1 }, | ||
| { 0, ref_coords[1], 0, 0, 1 }, | ||
| { 0, 0, ref_coords[0], 0, 1 }, | ||
| { 0, 0, 0, ref_coords[0], 1 }, | ||
| { (1 - ref_coords[2]), 0, (1 - ref_coords[0]), 0, 0 }, | ||
| { 0, (1 - ref_coords[2]), (1 - ref_coords[2]), 0, 0 }, | ||
| { 0, (1 - ref_coords[2]), 0, (1 - ref_coords[2]), 0 }, | ||
| { (1 - ref_coords[2]), 0, 0, (1 - ref_coords[2]), 0 } }; |
There was a problem hiding this comment.
Most of the values are calculated and not used
There was a problem hiding this comment.
Every value which is not 0 will get used at some point. Removing the 0's is not possible, since calling the lookup with the edge number wouldn't be possible anymore
Comment on lines
+472
to
+476
| const double orthogonal_direction[5] = { (ref_coords[0] - ref_coords[2]), (1 - ref_coords[0]), | ||
| (ref_coords[1] - ref_coords[2]), (1 - ref_coords[1]), ref_coords[2] }; | ||
| const double max_orthogonal_direction[5] | ||
| = { (1 - ref_coords[2]), (1 - ref_coords[2]), (1 - ref_coords[2]), (1 - ref_coords[2]), | ||
| (ref_coords[0] >= ref_coords[1] ? ref_coords[1] : ref_coords[0]) }; |
There was a problem hiding this comment.
Why are they not used?
test/t8_geometry/t8_geometry_implementations/t8_gtest_geometry_cad.cxx
Outdated
Show resolved
Hide resolved
| 1.0, 1.0, 1.0, 0.5, 1.0, 0.5, 0.0, 1.0, 0.0 }; // edge 7 | ||
| double curve_test_return_coords[9] | ||
| = { 0.0, 0.0, 0.0, // edge vertex 0 | ||
| 0.4999500215, 0.0000523914, 0.4000007585, // center of edge |
There was a problem hiding this comment.
Maybe T8_PRECISION_SQRT_EPS suffices and we can use 0.5 0 0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
This PR introduces a cad geometry interpolation algorithm for pyramid elements. With pyramids, t8code now features a cad mapping algorithm for all currently supported element shapes.
The PR also contains a test, which checks all possible linkages of a pyramid against a cad surface and a cad edge.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.Licence
doc/(or already has one)