-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with vector as input #1059
Open
Prasanna-Ponnusamy
wants to merge
50
commits into
main
Choose a base branch
from
test-with-vector-as-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davknapp
requested changes
May 6, 2024
Co-authored-by: David Knapp <[email protected]>
Co-authored-by: David Knapp <[email protected]>
Co-authored-by: David Knapp <[email protected]>
Co-authored-by: David Knapp <[email protected]>
This reverts commit d9d26d6.
Can you indent the files and take care for the failing tests please? |
… into test-with-vector-as-input
Davknapp
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Please address my comments and also add your code to the CMake build system.
Davknapp
added
priority: medium
Should be solved within half a year
workload: low
Would take half a day or less
enhancement
Enhances already existing code
C++
labels
Aug 14, 2024
Co-authored-by: David Knapp <[email protected]>
Co-authored-by: David Knapp <[email protected]>
… into test-with-vector-as-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C++
enhancement
Enhances already existing code
priority: medium
Should be solved within half a year
workload: low
Would take half a day or less
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Modified the existing t8_gtest_ghost_exchange file to take std::vector as input.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)