-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --gym-packages parameter to push_to_hub #315
Open
ernestum
wants to merge
19
commits into
DLR-RM:master
Choose a base branch
from
HumanCompatibleAI:gym_packages_for_push_to_hub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add --gym-packages parameter to push_to_hub #315
ernestum
wants to merge
19
commits into
DLR-RM:master
from
HumanCompatibleAI:gym_packages_for_push_to_hub
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace diverted MedianPruner by NopPruner * Update changelog Co-authored-by: Antonin RAFFIN <[email protected]>
* Dox fixes and move to python 3.7+ style * Fix type * Fix broken packages
…when enough trials are already present.
Add seals environments and corresponding (tentative) hyperparameters.
# Conflicts: # requirements.txt # rl_zoo3/import_envs.py
araffin
reviewed
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the commited changes do not correspond to the described feature, no?
EDIT: otherwise, this is indeed a needed feature.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--gym-packages
parameter to therl_zoo3.push_to_hub
command just like with therl_zoo3.train
command.Motivation and Context
For the
rl_zoo3.train
command line there is the--gym-packages
parameter to allow for importing foreign gym packages.When you want to upload the trained model to HuggingFace this will fail since the
rl_zoo3.push_to_hub
command has no such parameter and therefore the upload script won't be able to create an environment to render a preview for HuggingFace.Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)Note: we are using a maximum length of 127 characters per line