Additional units for sensor #212
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H_flow in MW since e.g. h = 2200 kJ/kg is nicer for the sensor display than h = 2200000 J/kg
|
Might not be necessary due to #215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might not be necessary due to #215
I suggest to add:
because this will yield 'nicer' values for the sensor display, e.g. the specific enthalpy of vaporization of water is always given as 2257 kJ/kg and never as 2257000 J/kg
Actually i would prefer a version, where we differentiate between display of the sensor (in non SI units) and output of a sensor (always in SI units) but this would cause major changes.