Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the examples:
SimpleStream
dropOfCommons.displayInstanceNames=true
anddropOfCommons.displayParameters=true
, becausedisplayParameters
helps a lot to get a quick overview of the boundary conditions anddisplayInstanceNames
helps especially for OpenModelica.pipe
,sensor
,splitter
,junction
instead of
flowResistance
,multiSensor_Tpm
,splitterT1_1
,junctionrT1_1
to make things simplerpipe
,pipe1
,pipe2
,pipe3
) instead offlowResistance3
,flowResistance2
,flowResistance1
,flowResistance4
to make things simplerdisplayParameters=true
C
, volumeV
and heat transfer areaA
to yield "more interesting" transients.SimpleAirCycle
2) Set
dropOfCommons.displayInstanceNames=true
anddropOfCommons.displayParameters=true
, becausedisplayParameters
helps a lot to get a quick overview of the boundary conditions anddisplayInstanceNames
helps especially for OpenModelica.2) Renamed components:
hex
,pipe
,instead of
heatExchange_CounterFlowNTU
,multiSensor_Tpm
,flowResistance
3) Added dynamicPressureInflow and outflowLoss to consider the dynamicPressure due to flight velocity and to consider the loss at outlet.
4) Removed splitter and junctions and added new sources and sinks to emphasize that simple and three wheel bootstrap cycle are different systems are not gonna be merged for the cabin.
5) Arranged components in text mode to make things simpler in variable browser (especially for OpenModelica)
6) Changed
turbine1.m_flow_ref
to yield same mass flow rates in both packs.7) Set initial values
m_flow.start(0)
Note: The simple cycle yields a better overall efficiency (the pack discharge temperature is lower) Is that correct? Note that the compressor barely compresses the flow, however the fan compresses a lot. We should definitely change
ThermofluidStream.Processes.Internal.TurboComponent.dp_tau_const_isentrop