Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example update #216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RaphaelGebhart
Copy link
Contributor

@RaphaelGebhart RaphaelGebhart commented Oct 15, 2024

Updating the examples:

SimpleStream

  1. More detailed documentation
  2. Set dropOfCommons.displayInstanceNames=true and dropOfCommons.displayParameters=true, because displayParameters helps a lot to get a quick overview of the boundary conditions and displayInstanceNames helps especially for OpenModelica.
  3. Renamed components: pipe, sensor, splitter, junction
    instead of flowResistance, multiSensor_Tpm, splitterT1_1, junctionrT1_1 to make things simpler
  4. Numbered them according to the flow direction (pipe, pipe1, pipe2, pipe3) instead of flowResistance3, flowResistance2, flowResistance1, flowResistance4 to make things simpler
  5. Arranged them in text mode (source - sink - pipes - splitter - junction - heat transfer - sensors, to make things simpler in variable browser (especially for OpenModelica)
  6. Changed the inlet pressure from Medium.p_default to 1 bar and the inlet temperature from Medium.T_default to 20 °C to make things simpler displayParameters=true
  7. Changed the heat capacity C, volume V and heat transfer area A to yield "more interesting" transients.

SimpleAirCycle
2) Set dropOfCommons.displayInstanceNames=true and dropOfCommons.displayParameters=true, because displayParameters helps a lot to get a quick overview of the boundary conditions and displayInstanceNames helps especially for OpenModelica.
2) Renamed components:hex, pipe,
instead of heatExchange_CounterFlowNTU, multiSensor_Tpm, flowResistance
3) Added dynamicPressureInflow and outflowLoss to consider the dynamicPressure due to flight velocity and to consider the loss at outlet.
4) Removed splitter and junctions and added new sources and sinks to emphasize that simple and three wheel bootstrap cycle are different systems are not gonna be merged for the cabin.
5) Arranged components in text mode to make things simpler in variable browser (especially for OpenModelica)
6) Changed turbine1.m_flow_ref to yield same mass flow rates in both packs.
7) Set initial values m_flow.start(0)

Note: The simple cycle yields a better overall efficiency (the pack discharge temperature is lower) Is that correct? Note that the compressor barely compresses the flow, however the fan compresses a lot. We should definitely change ThermofluidStream.Processes.Internal.TurboComponent.dp_tau_const_isentrop

@RaphaelGebhart RaphaelGebhart self-assigned this Oct 15, 2024
@RaphaelGebhart RaphaelGebhart marked this pull request as draft October 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant