Static head and tanks #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contain StaticHead components for both directional and undirectional cases,
TankCuboid and PartialTank for both directed and undirected cases, an AccelerationBoundary that is needed for these components, as well as a PartialSingleGasAndIncompressible media template with an instance JP8DryAir that works with the tank models. Additionally three basic incompressible media are added; JP8, Dowcal100 and Dowcal100E.
The issues #193 and #195 are resolved, but the PartialGasAndIncompressible class is still restrictive, mainly due to the specific functions needed in BaseProperties, which are customized to the SingleGases and Incompressible templates respectively.