Skip to content

Conversation

zbigniewj-se
Copy link

@zbigniewj-se zbigniewj-se commented Jan 4, 2024

Example of fix issue @#190

  • Example of passing an using the WarnCheck flag in code
  • Adding sEnum "NA"
  • Modification of the findPropItemforString method
  • Adding the getPropValue method
  • Sets default result value of property on N/A when WriteCheck flag is off
  • Sets default result value of property on False when WriteCheck flag is on
  • Example of updating property of resource.
  • Comment with an example of logic for updating the resource and checking whether the operation was successful, written in pseudocode.

Signed-off-by: Zbigniew Jedliński [email protected]

- Example of passing an using the WarnCheck flag in code
- Adding sEnum "NA"
- Modification of the findPropItemforString method
- Adding the getPropValue method
- Sets default result value of property on N/A when WriteCheck flag is off
- Sets default result value of property on False when WriteCheck flag is on
- Example of updating property of resource.
- Comment with an example of logic for updating the resource and checking whether the operation was successful, written in pseudocode.

Signed-off-by: Zbigniew Jedliński <[email protected]>
@mraineri
Copy link
Contributor

We've been discussing this change and I don't know if we can accept this as-is. The challenge we have with actively performing writes like this is it doesn't take into account if the value being written is something even allowed, or if the value would put the service into a bad state where it cannot continue testing. For example, I can imagine there being a profile requirement to make DHCP properties in EthernetInterface writable, but in doing so you could affect the interface being used for testing and lose connectivity with the service.

This area is definitely a gap in our testing that we'd like to close though; we just haven't figured out a good way of doing this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants