-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support: Relay randomization #1584
base: master
Are you sure you want to change the base?
Conversation
I'm not an expert on this, but only do 1 thing in 1 commit, please. |
@lifenjoiner Hey, thanks for your comment. Yes, you're right. I just simply followed commits on the original master branch on my fork, and unintentionally, it was pushed to the remote repo. my commit itself is actually only one for the feature. will revert it to the commit 02461e8. |
65cf7c0
to
02461e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, for example:
02461e8
to
e81f1ca
Compare
What's the status on this? It's been quite a while. |
Interesting feature. Thanks @junkurihara Apparently it's quiet over here. Feasible feature @jedisct1 ? |
This is an interesting feature, but it has a couple implications. What should Also, This code also conflicts with ODoH relays, which is why I postponed its review. One thing at a time :) ODoH may have introduced regressions in the way relays work, so the intent is to release a version with the ODoH set of changes first, and then look at how to add relay randomization on top of that. Order is arbitrary, but one thing at a time :) |
Hello @junkurihara . Just curious about the status of this feature. Would be great to have this. |
Hello @lsm5 ,
This PR to dnscrypt-proxy is currently pending. Also I did not implemented this feature based on ODoH yet. Here's my forked version tracking the master branch of original dnscrypt-proxy and having several additional features like relay randomization. If you like you can use it to use relay randamization. |
Hopefully you manage to 😊 thank you for the work and can't wait to try it! |
Would be great if this could be prioritized, it's the only PR on the repo right now and it's been well over a year since submission |
Is there an update on this by any chance? |
no news...???... :( |
750e928
to
9f3ef73
Compare
@junkurihara Were you able to get the ODoH-based support feature implemented in the end? 🤞🏽👀 |
The current solution is not that bad, and the wiki has been updated to:
That explains that @jedisct1 said about the In short, relay randomization is not for per request, but holds since each complete re-ranking. |
Hello,
In the documentation, the following was mentioned as caveats.
https://github.com/DNSCrypt/dnscrypt-proxy/wiki/Anonymized-DNS
I just implemented the relay randomization mentioned above (since I needed :-) ). The option of relay randomization can be enabled by making
relay_randomization
true indnscrypt-proxy.toml
. If this is enabled, one relay server is randomly chosen from an array of relay candidates at each query issuance.If you are okay, please review and consider to merge this commit. Thanks a lot for this quite nice software!