WEEK7 : 필수과제 완료 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pump9918
approved these changes
Dec 22, 2023
| if(it!=null) { | ||
| _signUpState.value = SignUpState.Success(it) | ||
| }else{ | ||
| _signUpState. value = SignUpState.Error |
| showToast("네트워크 에러 발생") | ||
| } | ||
| }) | ||
| authViewModel.signUp( |
There was a problem hiding this comment.
authViewModel의 signup과 버튼을 누르는 signup함수 이름이 같아서 조금 헷갈렸어요.
구분해주면 더 좋을 것 같아요!
jihyunniiii
approved these changes
Dec 24, 2023
|
|
||
| fun login(id: String, password: String) { | ||
| viewModelScope.launch { | ||
| kotlin.runCatching { |
There was a problem hiding this comment.
Suggested change
| kotlin.runCatching { | |
| runCatching { |
지워줘도 됩니둥
| val response = authService.signup(RequestSignUpDto(id, password, nickname)) | ||
| response.body() | ||
| }.onSuccess { | ||
| if(it!=null) { |
There was a problem hiding this comment.
하나의 UIState를 만들어서 적용할 수도 있답니다! LoginState와 SignUpState를 따로 나누지 않고요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚명세
🎬시연영상
급해죽겠는데ㅜㅜ 영상녹화가 안돼서 일단 캡쳐라도 했습니다 되면 바로 바꿔둘게욥
못했던 6주차 과제도 얼릉 끝내볼게요!!!!!!!!
💛과제리뷰
드디어 종강!!!!!
드디어 한가해졌숨당
그리고 드디어!!! 다음 주에 램16으로 업데이트하러 갑니다 ㅋ ㅋ
아직 라이브데이터나 코루틴, Flow 전부 다 너무 어렵고 이해가 잘 안돼서 앱잼 전에 공부하면서 합세 코드랑 셈나 과제 코드들 대거 리팩해보는게 목표입니당.
3달 안드 쫌 배웠다고 지금까지 쓴 코드가 되게 별로인게 눈에 보여요 ㅎ;;
아자자💪💘💘 지켜봐주세요