Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro problem with fragmented GIOP messages #1205

Merged
merged 7 commits into from
Dec 29, 2020

Conversation

j18ter
Copy link
Contributor

@j18ter j18ter commented Aug 19, 2020

This is a test to reproduce issue #1201. Not sure what needs to
be done to integrate this with the rest of the build, if anything.

Note, that I'm referencing a utility file from the examples
directory, not sure if this is frowned upon?

A free-standing variant of this test, which I was able to build and
test is here: TAO Fragmentation Bug

@jwillemsen jwillemsen added the needs review Needs to be reviewed label Aug 20, 2020
@jwillemsen
Copy link
Member

I would prefer not to use an example file from a completely different location

custom_only = 1
}

project(*Server): taoserver, namingexe, iortable, utils, avoids_corba_e_micro {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base projects need cleanup, way too much looking briefly at the test code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only base project I was able to remove without causing the build to fail was avoids_corba_e_micro. Note,
this whole example is just a copy of examples/Simple/echo with some tweaks to reproduce this bug. We don't
use MPC in our own projects and I don't know enough about MPC to do more than copy existing stuff with small
and obvious adjustments. I've pushed a change to remove avoids_corba_e_micro.

@jwillemsen jwillemsen requested review from jwillemsen and removed request for jwillemsen August 20, 2020 08:36
@j18ter
Copy link
Contributor Author

j18ter commented Aug 20, 2020

I would prefer not to use an example file from a completely different location

Unfortunately, this Simple_util.cpp file can't be dropped without completely rewriting the application. It could
be redundantly checked-in in the project directory, but this seems worse to me.

@jwillemsen
Copy link
Member

I would prefer not to use an example file from a completely different location

Unfortunately, this Simple_util.cpp file can't be dropped without completely rewriting the application. It could
be redundantly checked-in in the project directory, but this seems worse to me.

It is mostly setup code that you can easily copy from another test. By removing simple_util the dependency on the naming service can be removed again

#include "../../../examples/Simple/Simple_util.h"
#include "Echo_i.h"

// This is the main driver program for the time and date server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old comment

@jwillemsen
Copy link
Member

Please don't use std namespace, it isn't fully supported on all ACE/TAO supported platforms

@jwillemsen
Copy link
Member

Related to #1239

@jwillemsen jwillemsen merged commit 7894e00 into DOCGroup:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs to be reviewed
Development

Successfully merging this pull request may close these issues.

2 participants