Fixed Cube::fromIsd to add "LineScanTimes" table from HRSC isds#5705
Merged
Kelvinrr merged 4 commits intoDOI-USGS:devfrom Jan 17, 2025
Merged
Fixed Cube::fromIsd to add "LineScanTimes" table from HRSC isds#5705Kelvinrr merged 4 commits intoDOI-USGS:devfrom
Kelvinrr merged 4 commits intoDOI-USGS:devfrom
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5705". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
amystamile-usgs
force-pushed
the
Issue-5668
branch
from
033f19d to
f611af9
Compare
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5705". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5705". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
reviewed
Jan 13, 2025
Collaborator
acpaquette
left a comment
acpaquette
left a comment
There was a problem hiding this comment.
Overall looks good! Just a couple comments to address
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5705". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
approved these changes
Jan 14, 2025
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Apr 21, 2025
…USGS#5705) * in-progress-work * convert table back to isis * fix changelog * Addressed PR feedback
acpaquette
pushed a commit
to chkim-usgs/ISIS3
that referenced
this pull request
Apr 21, 2025
…USGS#5705) * in-progress-work * convert table back to isis * fix changelog * Addressed PR feedback
chkim-usgs
added a commit
that referenced
this pull request
Apr 22, 2025
* Update environment.yml (#5742) * Adds mkl to environment (#5747) * kaguyatc2isis invalid BandBin values (#5692) * Updates SpiceClient to handle redirect requests (#5696) * Jigsaw Fixes (#5703) * Add some fixes * Update changelog * Require update * Test fix * Fixed Cube::fromIsd to add "LineScanTimes" table from HRSC isds (#5705) * in-progress-work * convert table back to isis * fix changelog * Addressed PR feedback * Fix segfault from spiceclient (#5735) * Fix segfault from spiceclient * Updated changelog * getLocalNormal Reset (#5752) * Fixes getlocalnormal to reset image sample and line * Added changelog entry * Updated changelog entry * Fixes QView Min/Max bug (#5759) * Add qview min max fix * Update changelog * Fixes Juno kernels download (#5754) * Fixes Juno kernels download * added changelog entry * Embree Intersection Fix (#5769) * Fixed embree intersection computation * Fix embree local normal set and updated unittest * Updated truth data for embree target and shape model tests * Updated changelog * Open up rounding in embree tests * Updated embree target rounding to be more precise * findFeaturesSegment fixes (#5768) Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> * Updated changelog 9.0.0 release date * Ticked versions to 9.0.0 * Add mktl to meta.yaml run section (#5749) * Fixed bug where Lat/Lon/Radius point corrections are wrong in points.csv when running a rectangular (XYZ) bundle adjustment (#5688) * Fixed bug in the method BundleSolutionInfo::outputPointsCSV() where, when performing a rectangular (XYZ) bundle adjustment, the Lat/Lon/Radius point corrections written to points.csv are incorrect and do not match those written to bundleout.txt. Also modified the ctest FunctionalTestJigsawBundleXYZ to spot check six lines (points) in points.csv. Addresses #5646. * Removed unnecessary, duplicate calls to retrieve X,Y, and Z point :coordinates in method BundleSolutionInfo::outputPointsCSV. Addresses #5646. * Adjusted spacing on some changelog entries * Final Changelog updates from dev * Pull in dev meta and env files * Removed duplicate changelog entry * Disable jigsaw save/apply feature * Disabled jigsaw save/apply test --------- Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Adam Paquette <acpaquette@usgs.gov> Co-authored-by: kledmundson <6842706+kledmundson@users.noreply.github.com>
jrcain-usgs
added a commit
that referenced
this pull request
Dec 11, 2025
* Updates for 9.0.0 RC2 (#5706) * Jigsaw Fixes (#5703) * Add some fixes * Update changelog * Require update * Test fix * Version ticks for RC2 * Fix truth data for isis 9.0 * Moved bugfix version and rc back to appended string --------- Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> * Changes for 9.0 (#5707) * Updated build and run requirements with highfive * Adjusted whitespace to be consistent with previous version * remove the need to specify model and plugin (#5729) * 9.0.0 Release Prep (#5773) * Update environment.yml (#5742) * Adds mkl to environment (#5747) * kaguyatc2isis invalid BandBin values (#5692) * Updates SpiceClient to handle redirect requests (#5696) * Jigsaw Fixes (#5703) * Add some fixes * Update changelog * Require update * Test fix * Fixed Cube::fromIsd to add "LineScanTimes" table from HRSC isds (#5705) * in-progress-work * convert table back to isis * fix changelog * Addressed PR feedback * Fix segfault from spiceclient (#5735) * Fix segfault from spiceclient * Updated changelog * getLocalNormal Reset (#5752) * Fixes getlocalnormal to reset image sample and line * Added changelog entry * Updated changelog entry * Fixes QView Min/Max bug (#5759) * Add qview min max fix * Update changelog * Fixes Juno kernels download (#5754) * Fixes Juno kernels download * added changelog entry * Embree Intersection Fix (#5769) * Fixed embree intersection computation * Fix embree local normal set and updated unittest * Updated truth data for embree target and shape model tests * Updated changelog * Open up rounding in embree tests * Updated embree target rounding to be more precise * findFeaturesSegment fixes (#5768) Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> * Updated changelog 9.0.0 release date * Ticked versions to 9.0.0 * Add mktl to meta.yaml run section (#5749) * Fixed bug where Lat/Lon/Radius point corrections are wrong in points.csv when running a rectangular (XYZ) bundle adjustment (#5688) * Fixed bug in the method BundleSolutionInfo::outputPointsCSV() where, when performing a rectangular (XYZ) bundle adjustment, the Lat/Lon/Radius point corrections written to points.csv are incorrect and do not match those written to bundleout.txt. Also modified the ctest FunctionalTestJigsawBundleXYZ to spot check six lines (points) in points.csv. Addresses #5646. * Removed unnecessary, duplicate calls to retrieve X,Y, and Z point :coordinates in method BundleSolutionInfo::outputPointsCSV. Addresses #5646. * Adjusted spacing on some changelog entries * Final Changelog updates from dev * Pull in dev meta and env files * Removed duplicate changelog entry * Disable jigsaw save/apply feature * Disabled jigsaw save/apply test --------- Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Adam Paquette <acpaquette@usgs.gov> Co-authored-by: kledmundson <6842706+kledmundson@users.noreply.github.com> * 9.0.0 Docs Cherry-pick (#5778) * Move banner jpg out of repo to S3, not in public domain (#5680) * move banner, not public domain * delete moon-cr banner, unused * use same list for front page and regular menu * banner text - ISIS app manuals still here * ISIS App manuals vs new docs wording * grammar have -> has * Menu Fixes to Isis Docs (#5734) * Add in 9.0.0 menu option --------- Co-authored-by: Jacob Cain <115182890+jrcain-usgs@users.noreply.github.com> * Jigsaw fix (#5771) (#5779) * Save and write attributes * Remove Polygon and CamStats tables during apply stage * Update changelog * Refactor to account only for existing keys * Address feedback Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> * 9.0.0_RC3 Release Prep (#5783) * Re-enable jigsaw feature and test * Update docs for 9.0.0_RC3 release * GitHub Actions - Release Build (#5784) (#5789) * Github Actions Release * github release fixes * update secret name * Fixes tests * Adds doc step and dev biweekly build * Add in biweekly logic * Update github-release.yml * Update github-release.yml * ISIS 9 release prep (#5907) * readme change to trigger codebuild * std namespace for isinf * bump ale to 1.0.2 * Update FunctionalTestsSpiceinit.cpp to use clem_v21.tf (#5810) * pin cspice and spiceypy * trigger build * some fixes * Chandrayaan2 fixes and isisimport docs update (#5897) * Chandrayaan2 fixes and isisimport docs update * fix codebuild failures * test changes and tolerances * more tolerances * tolerances pt2 * thmbasemap1 tols * pin ale to 0.11.0 * pin ale 0.11.1 * meta.yaml ale 0.11.1 * code.json isis 9.0.0 * add missing section closer }, * regenerate authors isis 9.0.0 * match meta.yaml with environment.yml * changelog date, fixes post-isis9_RC3 * Update CHANGELOG.md --------- Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> Co-authored-by: Christine Kim <chkim@usgs.gov> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> * cmake lists stable isis 9.0.0 * meta.yaml isis 9.0.0 build 0 * code.json date for 9 prod release * update release runner to mac 14, 15 * don't label all other build LTS --------- Co-authored-by: Austin Sanders <arsanders@usgs.gov> Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Adam Paquette <acpaquette@usgs.gov> Co-authored-by: kledmundson <6842706+kledmundson@users.noreply.github.com> Co-authored-by: Christine Kim <chkim@usgs.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
closes #5668
How Has This Been Validated?
Added test
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: