PVL Core Rebase #5716
Closed
PVL Core Rebase #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* home, header, toc (minus images/icons) * application docs overview, parameters * formatting on specific isis docs * style changes - examples, print * usgs footer * print friendly css * isis-docs-sitewide css * header lock, add footer to main * icon assets (pd) * removed PrinterFriendly doc builds and old footers * mobile menu * header remove search, tabs scroll * menuPath for header assets, s3 common for fonts * remove ancient menu assets
…verted to a gtest and removed. (DOI-USGS#5600) * Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed. Addresses DOI-USGS#5599. * Modifications to address gtest failures. Also added addtional input parameter error checking to ensure noseam exits prior to generation of temporary files. Finally modified gtests to remove the print.prt file if generated. Addresses DOI-USGS#5599.
…output (DOI-USGS#5606) * added README.md * added pixel2map '23 mods * updated the 2023 code to the current dev branch * Started the refactoring * Added app functional test * updated files for refactoring * removed call to UserInterface in new cpp code * refactored started working * First functional test working * Removed unused headers * code reviewed with Kelvin * fixed Functional Test - started UnitTest * added the unit test cpp file in the tests folder * added new test, fixed code in case of 360 crossing * cleanup for PR * updated CHANGELOG and docs * updated institution info * removed commented-out lines in header * removed README.md * pixel2map definition re-inserted into Isis namespace (which was deleted during code cleanup) * change on testCube path reverted
* 8.3.0 changes * Add latest releases to docs
* Update downloadIsisData * Update downloadIsisData
* remove unused readthedocs template * Doxygen API Docs, header and footer, remove depreciated config * remove old vis * remove homepage windowing js * remove feed2js * remove progtest docs * remove isishistory and 'documents' structure * remove old vis (part 2) * remove unused toc and more unused javascripts * remove one more utility js reference * moved one-line files to inline in other files * menu arrow fix for api docs * move moon surface banner to be with rest of images * reorganized images * use menupath variable in more places * remove unused blackborderimage css * js.map files * favicon * css category fix * css category fix part 2 * css category fix part 3
…eometries. (DOI-USGS#5620) * Fixed issues with GisGeometry/Strategy classes. Addresses DOI-USGS#5612. * GisGeometry was throwing an exception when isValid() was called and the geometry was indeed invalid * GisGeometry - added buffer() method * Strategy was updated to better manage geometries * Strategy - Added RepairInvalidGeometry and InvalidGeometryAction to allow better user control over invalid geometries * Strategy - Apply buffer(0) algorithm when an invalid geometry is detected * Strategy - Added more debug output * Corrected invalid geometry problems in isisminer. Addresses DOI-USGS#5612. * GisGeometry was throwing an exception when isValid() was called and the geometry was indeed invalid * GisGeometry - added buffer() method * Strategy was updated to better manage geometries * Strategy - Added RepairInvalidGeometry and InvalidGeometryAction to allow better user control over invalid geometries * Strategy - Apply buffer(0) algorithm when an invalid geometry is detected * Strategy - Added more debug output * isisminer - improved handling of invalid/bad geometries * isisminer - Documented new parameters RepairInvalidGeometry and InvalidGeometryAction and updated Calculator strategy documentation * Fixed a bug in isisminer in which bad (e.g. self-intersecting) polygon geometries were not treated properly. Added pertinent unit tests to GisGeometry and Strategy classes. Fixed incorrect links and minor typos in isisminer documentation. Addresses DOI-USGS#5612. * Per reviewer comments, corrected additional typos in GisGeometry.cpp. Addresses DOI-USGS#5612. --------- Co-authored-by: Kris J. Becker <[email protected]>
…nd in the bundleout.txt file when performing a rectangular (XYZ) bundle adjustment, originally implemented in UofA OSIRIS-REx code on 2019-07-30. Addresses DOI-USGS#5642. (DOI-USGS#5643) * The RADIUS checkbox in the GUI is excluded when a RECTANGULAR solution is selected. * In the bundleout.txt file, for rectangular solutions, 1) RADIUS is set to N/A in the SOLVE OPTIONS section; and 2) the POINTS UNCERTAINTY SECTION was fixed to properly display adjusted point uncertainty statistics with Error Propagation turned on. * Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section. * Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution.
* Adds chandrayaan2 to isisimport * Addressed PR feedback
* speed up camstats * add changelog
* Fix xmltojson namespaced xml key conversion * Update xml test with namespaced elements * Added changelog entry
* Adds chandrayaan2 to isisimport * Adds archive info to chandrayaan2 * fixes to template * removed debugging from tests * remove xmltojson changes * small fixes
* Fix path issue, reduce redundant overlaps * Added comment * Remove old image_sets * Add check for match_segment_n * Revert overlap changes * updated script to improve times and fix bugs * added workdir param * made sure file are cleaned up when process fails * removed bug * fixes to tolist * Trigger build --------- Co-authored-by: Kelvin <[email protected]>
* fixes photomet not accepting backplanes * fix changelog * Converted to gtests * Add input cube attributes
* Convert dstripe to gtests * add changelog * Fixed build error
* Fixed app logging for all call able apps * Exposed error formatting and file line reporting flags on preference class * Updates IException to use the exposed Preference flags * Application handles adding program name to error * Initial round of test fixes * Fixed last 3 failing gtests * Fixed AppendAndLog function uses * Caught another missused AppendAndLog call * Fixed last failing gtest * Fixed output from getsn * Fixed mosrange test failures * Removed depricated method from PvlObject * Update recent app conversions to use the new function * Fixed additional addLogGroup calls
* update Auto in .trn files * update Optional in .trn files * updated mission specific .trn files with Auto * updated Debug in .trn files * Account for valueless PVL keywords that are not reserved keywords * Added dummy values for MappingGroupKeywords.pft * Update all files that are weren't PVL compliant * Fixed missing 'Debug' flag * Missed a couple of test updates * Addressed PR feeback * Reverted if logic since keywordNameUpper is also const * Added break when searching for reserved keyword * reverted gtest * Added changelog entries for PVL updates --------- Co-authored-by: Amy Stamile <[email protected]>
…S#5672) * Updated 'User Parameters' group to UserParameters for PVL compliance * Updated changelog
* Adds HRSC support in socetlinescankeywords * Add test cube * Fixed tests
* remove unused variable warnings * fix linux warnings * addressed PR feedback * fixes hinoise tests * Fix tests
* Added option for majority replacement * Updated changelog
* added release gitgub action * addressed feedback
* Fix SeedDomain SampleLine * Updated changelog * Removed ugmap
* Fixed small typo in isisimport.cpp * Added support for writing clipper line time tables for pushbroom images * Adjust Clipper EIS plugin name * Fixed clipper line time import function * Minor Clipper PB camera adjustments * Address breaking change * Capture detector offset in isisimport and the ClipperPushBroomCamera * Adjusted detector offset * Reverted detector origin * Updated Clipper pushbroom camera tests * Fixed detector center and offset * Fixes EIS Import Tests * Fixes ClipperPushBroomTests * Fix "Failed to open file" failures --------- Co-authored-by: amystamile-usgs <[email protected]>
* made the banner smaller * Updates to banner --------- Co-authored-by: amystamile-usgs <[email protected]>
* Small doc string changes * Fixed more doc strings and updated RTD configs * Added core docs * Removed path setup from config * Added subprocess import * Added back os import * Added breathe to env file * Maybe fix? * Added doxyfile * Trying doxygen change
* Moved wrapper under one package * Add pvl construction from reading a string, give access to blob internals * Updated meta.yaml to build isisio rather than isispvl
…ase-folding file system
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5716". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: