Proj Speed Up #479
Merged
Proj Speed Up #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/ProjectedCameraTests.cpp
Outdated
| csm::RasterGM * model = getUsgsCsmModelFromState(modelState, UsgsAstroProjectedSensorModel::_SENSOR_MODEL_NAME, NULL); | ||
|
|
||
| // When this is different, the output is very hard to parse | ||
| // TODO implement JSON diff for gtest |
There was a problem hiding this comment.
Is this something that needs to be done before merge, or just a QOL thing for debugging?
There was a problem hiding this comment.
This was a comment that was ripped from the line scan camera test that this was copied from. I can remove it just so we don't duplicate it
AustinSanders
approved these changes
Jul 26, 2024
chkim-usgs
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves proj CRS creation into camera instantiation and properly cleans up proj objects once finished.
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: