feat: 검증 로직 수정 및 로그아웃 구현 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sosow0212
approved these changes
Nov 30, 2025
Comment on lines
+86
to
+87
| fun logout(response: HttpServletResponse) { | ||
| refreshTokenCookieSupporter.expireRefreshTokenCookie(response) |
Contributor
There was a problem hiding this comment.
HttpServletResponse에 값을 심어주는 건 Controller에서 하는게 좋지 않을까요?
Comment on lines
30
to
31
| // /auth/reissue 엔드포인트가 쿠키를 받아 TokenResponse, 헤더를 정상 반환하는지 검증 | ||
| fun reissue_returns_tokenResponse_and_sets_cookie_header(){ |
Contributor
There was a problem hiding this comment.
fun 쿠키를_받아_response에_정상적으로_반환한다 이렇게 한글로 테스트명 표기해도 괜찮을 거 같아요~
한글 시작점과 끝점 사이에 백틱 '`' 사용하시면 돼요
|
|
||
| @WebMvcTest(AuthController::class) | ||
| @AutoConfigureMockMvc(addFilters = false) | ||
| class AuthControllerReissueTest { |
Contributor
There was a problem hiding this comment.
단위 테스트 좋습니다~ 실제 작동을 테스트하는 E2E 테스트는 조금 익숙해지면 해도 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 작업 내용
인증 플로우
/auth/login: OAuth2 성공 시 refreshToken을 쿠키로 설정하고 /auth/callback으로 리다이렉트콜백 후
/auth/reissue호출 시 쿠키에 담긴 refreshToken으로 accessToken을 재발급하고, accessToken만 body로 반환accessToken 만료 시
/auth/reissue로 재발급/auth/logout호출 시 refreshToken 쿠키를 즉시 만료시킴RefreshTokenCookieSupporter로 쿠키 발급, 삭제 로직 분리
테스트코드 작성
close #10