패키지 리뷰 기능 추가 #18
Merged
패키지 리뷰 기능 추가 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustj3104
approved these changes
Dec 9, 2025
Contributor
gustj3104
left a comment
gustj3104
left a comment
There was a problem hiding this comment.
스웨거 도입 확인했습니다!
BaseEntity(CreatedAt, UpdatedAt, DeletedAt), Custom 예외처리는 추후에 작업하는 걸까요? 아니면 작성하신 것처럼 텍스트 메시지로 처리하는 게 나을까요?
Comment on lines
44
to
45
| require(packageRepository.existsById(packageId)) { "Package $packageId does not exist." } | ||
| return packageRepository.getReferenceById(packageId) |
Contributor
There was a problem hiding this comment.
findById로 DB 1회만 조회하는 방식은 어떤가요?
Contributor
Author
There was a problem hiding this comment.
엇 두 번 조회하고 있었네요 확인했습니다!
pr 메시지에 대해선 추후 작업해도 괜찮을 것 같아서 일단은 기본 예외를 썼습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 작업 내용
패키지 리뷰 관련한 CRUD 기능을 추가 했습니다.
PackageReviewApi에 스웨거를 추가했으니 작업하실 때 참고 부탁드릴게요!
브랜치를 이미지 브랜치에서 파서 이미지 코드가 일부 섞여있는데, 해당 부분은 무시해주세요!
실제 커밋 범위
🙋🏻 이슈 / 궁금증 / 추가사항
close #15