마이페이지 및 패키지 예약 관련 API 추가 #30
Merged
+1,427
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustj3104
reviewed
Dec 31, 2025
Contributor
gustj3104
left a comment
gustj3104
left a comment
There was a problem hiding this comment.
패키지, 리뷰까지 조회하고 있어서 구현하신 대로 MyPageController를 분리하는 게 좋을 것 같습니다! 유저 정보 조회까지 마이페이지 조회로 옮기는 건 어떤가요?
닉네임을 2-10자, 영어+숫자로 제한하고 있어서 예외처리를 추가하면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 작업 내용
마이 페이지
패키지
🙋🏻 이슈 / 궁금증 / 추가사항
MyPageController를 별도로 분리한 이유는, 데이터 조회를 할 때 여러 애그리거트를 건들게 되는데, 추후 조회용 서버가 추가된다면 경량쓰레드를 써서 각 API Call을 효율적으로 할 수 있지 않을까 하고 분리를 했는데 지금 보면 오버엔지니어링 같기도 하고 지금 시점에선 좋아 보이진 않는 것 같습니다.
현서님은 어떻게 생각하시는지 의견 부탁드릴게요!
close #29