Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bcmath for DOMjudge/domjudge#2954 #218

Merged
merged 1 commit into from
Mar 15, 2025
Merged

Add bcmath for DOMjudge/domjudge#2954 #218

merged 1 commit into from
Mar 15, 2025

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Mar 15, 2025

This would make that pipeline a bit faster.

@vmcj vmcj requested a review from meisterT March 15, 2025 11:25
meisterT
meisterT reviewed Mar 15, 2025
View reviewed changes
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is that we test with different PHP versions, and we need to install bcmath for the one under test.

@vmcj
Copy link
Member Author

vmcj commented Mar 15, 2025

Problem is that we test with different PHP versions, and we need to install bcmath for the one under test.

Yes, but we have this ugly hack here: https://github.com/DOMjudge/domjudge-packaging/pull/218/files#diff-3b0da9e503e60c29d6b49c1252c691e9910c6ec67d342549b42ad999d9719ab4R44 which should pick that up for you.

@vmcj vmcj added this pull request to the merge queue Mar 15, 2025
Merged via the queue into main with commit 10dfd94 Mar 15, 2025
4 checks passed
@vmcj vmcj deleted the vmcj-patch-1 branch March 15, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmcj @meisterT