Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print files as team using the API #2847

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Print files as team using the API #2847

merged 4 commits into from
Nov 26, 2024
+248 −18

Conversation

Kevinjil
Copy link
Contributor

@Kevinjil Kevinjil commented Nov 23, 2024 •
edited
Loading

This includes:

  • sharing some code between controllers
  • the API endpoint
  • the submit client for workstations

fixes #2759

@Kevinjil
Define a service function for printing as a user
8330284 
Share some code which is used in multiple controllers, and allow this
shared code to be used by API endpoints in the future.
@Kevinjil Kevinjil force-pushed the print-api branch 14 times, most recently from a3e687b to 8e8e418 Compare November 24, 2024 13:27
@Kevinjil Kevinjil marked this pull request as ready for review November 24, 2024 13:34
@Kevinjil
Define API endpoint for printing as a team
f409cb4 
This endpoint can be used for `printfile` CLI submit tools, when
printing via DOMjudge has been configured.
@Kevinjil
Allow printing from the submit client
655e246 
To allow easy deployments, have printing and submitting in the same
python file such that we can share code without need to import library
files.
For convenience of teams, you probably want to alias `printfile` to the
submit client with predefined `--print` argument to prevent any
accidental submission.
@Kevinjil
Adjust integration test for printing API
b35ac4d
@Kevinjil
Copy link
Contributor Author

As the language is not required in the web UI, I also made it optional in the API.

@Kevinjil Kevinjil added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 87cbe4e Nov 26, 2024
34 checks passed
@Kevinjil Kevinjil deleted the print-api branch November 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an API endpoint for printing
2 participants
@Kevinjil @nickygerritsen