Properly restrict clarification thread to team. #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the following could happen: - team A requests a clarification, potentially including details the jury doesn't want to broadcast - the jury replies to everyone, removing the part from the question that they don't want to have broadcasted - team B views the reply from the jury, sees the whole clarification thread Found while working on DOMjudge#3087
meisterT
force-pushed
the
clars_restric
branch
from
881cb36 to
bbdb3b5
Compare
vmcj
reviewed
Sep 7, 2025
nickygerritsen
approved these changes
Sep 8, 2025
We do have threads, in case they are accessible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the following could happen:
Found while working on #3087