Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cambio ICONE #33

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from
Open

Cambio ICONE #33

wants to merge 55 commits into from

Conversation

davimarz
Copy link

@davimarz davimarz closed this Apr 24, 2020
@davimarz davimarz reopened this Apr 24, 2020
@dilox dilox force-pushed the develop branch 2 times, most recently from d090be6 to fecb5c7 Compare April 27, 2020 18:39
# By Clea Benz (3) and Christoph Maurhofer (1)
# Via GitHub (2) and Clea Benz (1)
* dp3t/develop:
  review changes
  correct naming
  only show debug screen for dev builds. and remove classes from prod build
  Added a debug screen for additional status information and interaction possibilities

# Conflicts:
#	app/src/main/res/values-it/strings.xml
@markusb
Copy link

markusb commented Apr 30, 2020

A remark: These Icons have Italian text, so they presume that Icons have localized text and therefore we need to maintain at least four sets of icons (D/F/I/E). I think this is a bad idea. Icons should have no text at all, so that the same icon can be used for all localisations/languages.

@davimarz
Copy link
Author

the common project for the whole community started from Italy, I wanted to clarify it, now there are implications, and we will decide together with a vote if and what to change.
@markusb yours is a right observation leads to graphic strategies, to be recognized immediately, here we talk about brands, but this goal is under development, we have already voted for it, and it will be the next step

@markusb
Copy link

markusb commented Apr 30, 2020

@davimarz: Thanks for the clarifications. But I don't know what precise goal has been voted for and what implications this has on icon text. So it has been voted that the icon contains localized text ? I'll just shut up then.

A parallel question of mine is then the application name, currently 'next step', see issue #39. This concerns branding too and might have been voted for (=immutable), too.

silicia-apps and others added 27 commits May 3, 2020 18:56
[UPD] extract version from git using describe
Add PopUp PING-PONG bluetooth fra device
[FIX] Necessario reboot device dopo 'Ripristino SDK'
removed empty line
versionCode is defined through git's tag with codeFormat MNNPPP where
M: major, N minor, P patch version + a baseCode to skip github CI workflow
errors when major number is 0 (see below for error)

GitHub CI workflow error (without baseCode):

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> android.defaultConfig.versionCode is set to 0, but it should be a positive integer.
  See https://developer.android.com/studio/publish/versioning#appversioning for more information.
resize image onBoardingPermission, autoScroll fragment
Translate Android front end labels into French
adding empty line for consistency #44
[UPD] versionCode from git's tag + basecode (90000000)
Graphic fix on Wizard onboarding for improve accessibility
@davimarz
Copy link
Author

qualcuno potrebbe chiudere questa PR, é errata. grazie

bbossola and others added 2 commits May 22, 2020 17:38
This add the Meterian badges to the project, which will be now checked daily in order to detect any vulnerable or out of date component.
Added Meterian badges to README.MD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.