Added security check profile and fixed some issues #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iCesofT
commented
Oct 6, 2020
iCesofT
commented
- Added dependendency-check-maven to check security.
- Added log4j2 dependencies to 2.13.3 because of CVE-2020-9488.
- Added dependendency-check-maven to check security. - Added log4j2 dependencies to 2.13.3 because of CVE-2020-9488.
|
Thanks for the input. We currently use logback as logger. Does this even work if we just add log4j2? Can we have both loggers side by side? |
|
I know that you are using logback but the spring logging s using log4j-api to catch all log4j2 logging and set them to slf4j. Take into account that the added dependency is included in dependencyManagement not as dependency. See that log4-api is included when you create the war/jar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.