Skip to content

Commit

Permalink
net/sfc: avoid duplicate configuration restore
Browse files Browse the repository at this point in the history
MAC address, promiscuous and all-multicast modes are restored correctly
upon device start by the PMD itself. ethdev layer should not duplicate it.

Signed-off-by: Andrew Rybchenko <[email protected]>
  • Loading branch information
ol-andrewr authored and shemminger committed Dec 17, 2024
1 parent 6c7e4bf commit 6f97992
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/net/sfc/sfc_ethdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -2722,6 +2722,14 @@ sfc_fec_set(struct rte_eth_dev *dev, uint32_t fec_capa)
return -rc;
}

static uint64_t
sfc_get_restore_flags(__rte_unused struct rte_eth_dev *dev,
__rte_unused enum rte_eth_dev_operation op)
{
/* sfc PMD does not require any configuration restore */
return 0;
}

static const struct eth_dev_ops sfc_eth_dev_ops = {
.dev_configure = sfc_dev_configure,
.dev_start = sfc_dev_start,
Expand Down Expand Up @@ -2774,6 +2782,7 @@ static const struct eth_dev_ops sfc_eth_dev_ops = {
.fec_get_capability = sfc_fec_get_capability,
.fec_get = sfc_fec_get,
.fec_set = sfc_fec_set,
.get_restore_flags = sfc_get_restore_flags,
};

struct sfc_ethdev_init_data {
Expand Down

0 comments on commit 6f97992

Please sign in to comment.