Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: add short target to build with debug options #107

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

rjarry
Copy link
Collaborator

@rjarry rjarry commented Dec 5, 2024

Add a debug target that will force BUILDTYPE=debug and SANITIZE=address.

Add a debug target that will force BUILDTYPE=debug and SANITIZE=address.

Signed-off-by: Robin Jarry <[email protected]>
@david-marchand
Copy link
Member

One problem with this patch is that the debug target does not "configure" the sources.

Example:

$ git clean -xffd
$ make
...
Found ninja-1.11.1 at /usr/bin/ninja
ninja: Entering directory `build'
[704/704] Linking target grout

$ make debug
ninja: Entering directory `build'
ninja: no work to do.

@rjarry
Copy link
Collaborator Author

rjarry commented Dec 9, 2024

For this we would have to use meson configure and it can be a bit fragile. Sometimes, not all sources get recompiled with new options.

rm -rf build && make debug

Seems safer but I don't want to always delete everything.

@rjarry rjarry force-pushed the main branch 4 times, most recently from 5c890dd to d9c6ad3 Compare January 8, 2025 16:55
@rjarry rjarry merged commit 86c3659 into DPDK:main Jan 8, 2025
6 checks passed
@rjarry rjarry deleted the debug branch January 8, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants