main: improve api socket bind #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjarry
requested changes
Jan 8, 2025
rjarry
force-pushed
the
main
branch
4 times, most recently
from
5c890dd to
d9c6ad3
Compare
If the grout process is launched a second time, then socket api bind() failed and the process unlink socket file before exiting, making the first running process unreachable. If the grout process crash, it won't remove api socket file, and the next invocation will fail at socket api bind(). Change api_socket_start() to check, if bind() fails, whether there's a listening process behind the scene: * If there is, exit without removing socket api file * If there is not, then remove file and resume bind. Signed-off-by: Olivier Gournet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the grout process is launched a second time, then socket api bind() failed and the process unlink socket file before exiting, making the first running process unreachable.
If the grout process crash, it won't remove api socket file, and the next invocation will fail at socket api bind().
Change api_socket_start() to check, if bind() fails, whether there's a listening process behind the scene: