[Week/#1] 1주차 워크북 미션 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldeoddt
reviewed
Oct 1, 2024
| @@ -7,13 +7,142 @@ | |||
| android:layout_height="match_parent" | |||
| tools:context=".MainActivity"> | |||
|
|
|||
| <ImageView | |||
| android:id="@+id/backbtn" | |||
There was a problem hiding this comment.
id 네이밍 시 btn_back 형식으로 snake case 사용하면 좋을 것 같아요
textview의 경우 tv_menu_title 이런 형태를 주로 사용합니다!
eldeoddt
reviewed
Oct 1, 2024
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="Hello World!" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| android:text="오늘 하루는 어땠나요?" |
There was a problem hiding this comment.
textview의 text 속성 사용 시
res-values-strings.xml에서 string을 지정하여 사용하면 좋을 것 같아요!
eldeoddt
reviewed
Oct 1, 2024
| android:orientation="vertical" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/text3" | ||
| app:layout_constraintEnd_toEndOf="parent"> |
There was a problem hiding this comment.
LinearLayout에 layout_constraintBottom_toBottomOf="parent"
bottom constraint도 추가하면 화면 크기에 따라 이미지가 잘리지 않을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
#1
✅ Key Changes
📢 To Reviewers (Part Leader)
ConstraintLayout, LinearLayout을 이용하여 단일 화면을 구성했습니다.
이미지는 SVG Vector asset으로 가져왔습니다.
📸 스크린샷
🔗 참고 자료