Added inventory-code.md v1 (removed hidden button)#3
Closed
decause-gov wants to merge 1 commit intomainfrom
Closed
Added inventory-code.md v1 (removed hidden button)#3decause-gov wants to merge 1 commit intomainfrom
decause-gov wants to merge 1 commit intomainfrom
Conversation
natalialuzuriaga
requested changes
May 8, 2025
natalialuzuriaga
left a comment
natalialuzuriaga
left a comment
There was a problem hiding this comment.
Requested to move code.json example file div code. Also should we consider using markdown instead? But it still looks great using HTML
| </tbody> | ||
| </table> | ||
| </div> | ||
| </div><div id="how-to-inventory-b"><div><h2 id="examplecodejsonfile">Example code.json file</h2> |
There was a problem hiding this comment.
This is not aligned with the rest of the content in the page so I would move this to under the table tag in line 172
|
Would consider running a linter on this too for readability but not blocking |
Author
|
Replaced by #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module-name: Added How To Inventory Code Page
Problem
Page explaining the How To Inventory Code was missing
Solution
Ship it!
Result
Test Plan
Viewed in markdownlivepreview.com, will install the whole npm stack in the future maybe ;)