-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added date created functionality for code.json #153
Conversation
Signed-off-by: sachin-panayil <[email protected]>
…ffolder into nat/req-fields-code-json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just update the field name but otherwise LGTM! Works perf on my end
tier1/{{cookiecutter.project_slug}}/.github/repometrics/hooks/post_gen_project.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues with file operation exception handling but otherwise looks good.
tier1/{{cookiecutter.project_slug}}/.github/repometrics/hooks/post_gen_project.py
Outdated
Show resolved
Hide resolved
Signed-off-by: sachin-panayil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
created a way to capture the date the repo was created for code.json only in tier 1. once this functionality is approved, it should be copied into the rest of the tiers.