-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support semantic context of isNewStatement #361
Open
JackWang032
wants to merge
2
commits into
DTStack:next
Choose a base branch
from
JackWang032:feat/sql_snippets
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyFBB
reviewed
Nov 6, 2024
liuxy0551
reviewed
Nov 6, 2024
JackWang032
force-pushed
the
feat/sql_snippets
branch
from
November 15, 2024 06:45
6bccb36
to
9b8d7b1
Compare
liuxy0551
approved these changes
Nov 26, 2024
JackWang032
force-pushed
the
feat/sql_snippets
branch
from
December 18, 2024 05:57
9b8d7b1
to
e05e5bd
Compare
新增支持配置切分策略 当策略为 SELECT id FROM t1
CREATE SELECT语句后没有显式以分号结尾,那么 配置方式: const { isNewStatement } = flinkSql.getSemanticContextAtCaretPosition(
sql,
{
lineNumber: 2,
column: 7,
},
{
sqlSplitStrategy: SqlSplitStrategy.STRICT,
}
); |
liuxy0551
reviewed
Jan 2, 2025
JackWang032
force-pushed
the
feat/sql_snippets
branch
from
January 3, 2025 01:57
58a65fe
to
0d7de53
Compare
|
JackWang032
force-pushed
the
feat/sql_snippets
branch
from
January 3, 2025 06:21
7c11ea2
to
6671803
Compare
Docs done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
新增语义上下文( semanticContext ) -
isNewStatment
用于判断当前输入位置是否处于一条新语句开头(基于语法文件)。改动点
SemanticContextCollector
实现类用于收集语义上下文basicSQL
中新增getSemanticContextAtCaretPosition
方法用于获取语义上下文信息使用