Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature splinemodefix #28

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Feature splinemodefix #28

merged 2 commits into from
Jan 24, 2025

Conversation

libanwars
Copy link
Contributor

Previously if splines were found in a spline file for interaction modes that weren't specified in the systematic yaml fike, an error would be thrown.

This is unnecessary, instead, these interaction modes are identified and how many haven't been read/which modes is shown in the output.

Liban Warsame added 2 commits November 7, 2024 13:02
…hen spline has been found for a mode which wasn't specified in the cov yaml
Copy link
Member

@dbarrow257 dbarrow257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully will stop any of the previous issues that we were seeing

@dbarrow257 dbarrow257 merged commit 50dae1c into develop Jan 24, 2025
@dbarrow257 dbarrow257 deleted the feature_splinemodefix branch January 24, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants