First pass at enabling FlatCAF making in ND #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to wait until after Luke has a whack at addressing #11? He said he'll try it next week. |
cjbacchus
force-pushed
the
feature/flatcafs
branch
from
fe5a7c3 to
bfba425
Compare
|
I got this to build using the set of libraries in ndcaf_setup.sh, plus various other downstream changes. Doesn't run though. |
chenel
force-pushed
the
feature/flatcafs
branch
3 times, most recently
from
c0cd5dc to
b7e3204
Compare
|
I had to substantially rewrite the first few commits to undo all the changes to the build system since we've moved well beyond the versions that this PR wanted, but the basic substance still worked. I added a few bits to also make flatCAF-making optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is approximately how it should look. Unfortunately it needs a newer C++/ROOT than is setup by default, and the ND_CAFMaker software setup is such a disaster that I haven't yet managed to get such a configuration to test.
There will also need to be some configuration options to enable/disable this, which I'm not sure how they should look.