-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CMakeLists and added PDVD PDS Mapping implementation #79
base: develop
Are you sure you want to change the base?
Conversation
Hi @Kaixin-Zhu, I think this should go here. Also, have a look at the map from PDHD, which refers to the link/slot/daphne channels from hardware used to import the raw data. We need the same for VD. I suggest having just one map for all. Is the channel numbering the same as default? or is it changing with this table? Thanks a lot! |
@jroto This mapping is very flexible and new variables can be included as needed. In principle, I asked Kaixin to include a hardware channel (this is the naming we used in PDSP), which would be the Daphne channel, so that channel is the channel in LArSoft. We may change this to OpChannel to make it clearer. What do you think? |
Slot+DaphneChannels is the minimum we need to know which hardware channel we are talking about, because we can have the same Daphne channel for different slots. What about something like this? The channel in LArSoft we usually call it in PDHD "offline channel", I'm not sure if I was clear, I tried to follow your naming. We should talk to Manuel and the analyzers, I'm sure they already did a mapping. |
I agree with you, José, this should probably go into duneprototypes. |
@Kaixin-Zhu do you mind making these changes that José requested? |
This update is the channel mapping support for the ProtoDUNE Vertical Drift Photon Detector System. I've added the following new files: PDMapAlg.h, PVDV_PDMapAlg.hh, PVDV_PDMapAlg_tool.cc, PVDV_PDS_Mapping.json, and json.hpp. And two new lines have been added to the bottom of CMakeLists.txt to support the new PDVD PDS Mapping feature.