Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CMakeLists and added PDVD PDS Mapping implementation #79

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Kaixin-Zhu
Copy link
Member

This update is the channel mapping support for the ProtoDUNE Vertical Drift Photon Detector System. I've added the following new files: PDMapAlg.h, PVDV_PDMapAlg.hh, PVDV_PDMapAlg_tool.cc, PVDV_PDS_Mapping.json, and json.hpp. And two new lines have been added to the bottom of CMakeLists.txt to support the new PDVD PDS Mapping feature.

@jroto
Copy link
Member

jroto commented Feb 18, 2025

Hi @Kaixin-Zhu, I think this should go here.

Also, have a look at the map from PDHD, which refers to the link/slot/daphne channels from hardware used to import the raw data. We need the same for VD. I suggest having just one map for all.

Is the channel numbering the same as default? or is it changing with this table?

Thanks a lot!

@lpaulucc
Copy link
Member

@jroto This mapping is very flexible and new variables can be included as needed. In principle, I asked Kaixin to include a hardware channel (this is the naming we used in PDSP), which would be the Daphne channel, so that channel is the channel in LArSoft. We may change this to OpChannel to make it clearer. What do you think?
Do you mind making a list of the information you would like to be included in the map? Just slot and link or more things too?

@lpaulucc lpaulucc requested review from jroto and lpaulucc February 19, 2025 13:46
@jroto
Copy link
Member

jroto commented Feb 19, 2025

Slot+DaphneChannels is the minimum we need to know which hardware channel we are talking about, because we can have the same Daphne channel for different slots.
What about the capability of having two different hardware channels (slot+daphne channel) per OpChannel (XArapuca)? Maybe we can add a vector of hardware channels per OpChannel?

What about something like this?
{
"OpChannel": 16,
"pd_type": "Membrane + Q",
"sens_Ar": false,
"sens_Xe": true,
"eff": 0.03,
"HardwareChannel": [ {"Slot": X, "DaphneChannel" : Y, OfflineChannel: 1600} , {"Slot": Z, "DaphneChannel" : Z2, OfflineChannel: 1601} ]
},

The channel in LArSoft we usually call it in PDHD "offline channel",

I'm not sure if I was clear, I tried to follow your naming.

We should talk to Manuel and the analyzers, I'm sure they already did a mapping.

@lpaulucc
Copy link
Member

I agree with you, José, this should probably go into duneprototypes.
Regarding the PDVD map, when I left CERN, things were not exactly connected to Daphne and since no work could be done at the NP... But sure, let's ask Manuel about it. I have something from Dante but he said things could still change.

@lpaulucc
Copy link
Member

@Kaixin-Zhu do you mind making these changes that José requested?
We could add 1 or 2 to slot, daphne channel and offline channel, maybe it is easier to handle than the vector.

@Kaixin-Zhu
Copy link
Member Author

Hi @jroto @lpaulucc, We can certainly add hardware channels (slot + Daphne channel) and offline channels to the map. I don’t think writing it as a vector would be too difficult, so we can use either a vector or scalar—whichever you think is better. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants