Change adc range from 12 to 14 bits, new DAQ standard

[emanuele-villa]

This shall go in only after changes in dunereco/DUNEWirecell, where we're moving from 12 to 14 as well.

Note that the DAQ standard has been 14 for a long time now, but the value was never updated.

(duplicate of another MR that was reverted, this shall remain a draft for a while)

[emanuele-villa]

After this commit, this MR shall go in develop after DUNE/dunecore#141

[emanuele-villa]

By testing I realised I was making a mistake: can't include in a tools fcl. Therefore, I just updated the Nbit value with a comment.

[tomjunk]

A question -- does this affect PDSP MC? I think we simulated some new MC recently for PDSP.

[tomjunk]

Added Jake and Tingjun as reviewers.

[tomjunk]

Looks like dunecore PR 141 adds legacy support.

[emanuele-villa]

A question -- does this affect PDSP MC? I think we simulated some new MC recently for PDSP.

I left the value of Nbit = 12 in all pdsp fcl configuration in wirecell_dune.sh. Given that now Nbit (aka resolution) is always read from fcl, there should be no problem.

[tomjunk]

Approved

[aolivier23]

trigger build

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[aolivier23]

trigger build

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

⚠️ CI build for DUNE Succeeded with warning at phase build on slf7 for c14:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[aolivier23]

This PR fails a regression test. You can see an example here:
36: test_IdealAdcSimulator: /scratch/workspace/dune_ci/label_exp/swarm/label_exp2/swarm/DUNE/srcs/dunesim/dunesim/DetSim/Tool/test/test_IdealAdcSimulator.cxx:34: void checkEqual(T1, T2, std::string) [T1 = unsigned short, T2 = unsigned short]: Assertion `false' failed.

@tomjunk do you know what that regression test is testing for? Can we get around it somehow?

[FNALbuild]

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for DUNE Succeeded with warning at phase build on slf7 for c14:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[aolivier23]

Realized that this PR depends on 1 or more other PRs. I'll merge them all then try again and deal with the consequences.

[aolivier23]

@emanuele-villa I had to revert this because it breaks a regression test. Looks like an easy fix with your knowledge of how the ADCs work. You have to create a new PR with the branch from this PR and go back through the PR process. Sorry for the mess, I merged this hoping the new Wirecell version would let me fix some problems.

[emanuele-villa]

I suspect it could be because there is a comment after the value Nbit: 14...

[emanuele-villa]

this PR in the end does not depend on any other, so it should not be the problem

[tomjunk]

I think the problematic line with the unit test is here.