Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let develop be data-able, plus some reflowing stuff #145

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

diaza
Copy link
Member

@diaza diaza commented Nov 13, 2024

The only files to check are the ones without module1 or module2 in the filename, src/proto_nd_flow/reco/charge/raw_event_generator.py and src/proto_nd_flow/reco/charge/calib_prompt_hits.py, which needed to be made data-able.
The rest is reflow stuff that got caught in this messy branch.

@diaza
Copy link
Member Author

diaza commented Nov 13, 2024

Looped in @edhinkle in case they had qualms about their commits being pulled in

@edhinkle
Copy link
Member

Thanks for checking in! While almost all the changes in my commits only affect Module 1 simulation and/or data reflowing, it looks like I made two small changes to data/proto_nd_flow/2x2.yaml in aafba85 to two light MC parameters, max_light_truth_ids and
mc_truth_threshold. I can't recall exactly why these changes were included in this particular commit/branch, and it very well could have been a mistake on my part. Either way, I don't think it's a huge deal because it's only two parameters/lines, but this is the only change I made which I think might warrant further scrutiny.

Copy link
Member

@krwood krwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a sanity check, can we process a simulation file from MR6 with this branch and have a look at the validation plots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants