-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let develop be data-able, plus some reflowing stuff #145
base: develop
Are you sure you want to change the base?
Conversation
…dule cosmics simulation.
…ule cosmics simulation.
…ture_module1_reflow
Looped in @edhinkle in case they had qualms about their commits being pulled in |
Thanks for checking in! While almost all the changes in my commits only affect Module 1 simulation and/or data reflowing, it looks like I made two small changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a sanity check, can we process a simulation file from MR6 with this branch and have a look at the validation plots?
The only files to check are the ones without module1 or module2 in the filename, src/proto_nd_flow/reco/charge/raw_event_generator.py and src/proto_nd_flow/reco/charge/calib_prompt_hits.py, which needed to be made data-able.
The rest is reflow stuff that got caught in this messy branch.