Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add io_group and io_channel to calib_prompt_hits and calib_final_hits datasets #88

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Add io_group and io_channel to calib_prompt_hits and calib_final_hits datasets #88

merged 2 commits into from
Dec 15, 2023

Conversation

edhinkle
Copy link
Member

Two fields, io_group and io_channel, are added to the calib_hits_dtype in proto_nd_flow and filled in calib_prompt_hits. These changes also cause the same fields to be filled in calib_final_hits.

@edhinkle edhinkle requested a review from krwood December 14, 2023 22:50
@edhinkle
Copy link
Member Author

Validation plots are attached here. Distributions derived from the packets dataset are achieved through referencing between calib_prompt_hits and packets.

@edhinkle edhinkle linked an issue Dec 14, 2023 that may be closed by this pull request
Add "io_group" and "tile" information to the hit dataset #82
Closed
@YifanC YifanC merged commit 3a03882 into develop Dec 15, 2023
2 checks passed
@edhinkle edhinkle deleted the feature/ehinkle_iogroup_tileid_to_hits_datasets branch October 2, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krwood krwood Awaiting requested review from krwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "io_group" and "tile" information to the hit dataset
2 participants
@edhinkle @YifanC