Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #91

Merged
merged 43 commits into from
Dec 20, 2023
Merged

Develop #91

merged 43 commits into from
Dec 20, 2023

Conversation

diaza
Copy link
Member

@diaza diaza commented Dec 20, 2023

No description provided.

krwood and others added 30 commits October 13, 2023 16:52
@krwood
do not ask to remove file
74a0386
@krwood
adds backtracking dataset for calib_prompt_hits in a way that mirrors…
2c628ef 
… the backtracking dataset for calib_final_hits
update the geometry script to match with the module0 one
99a013b
remove the inflation factor of the size estimation
a14d954
@krwood
Merge pull request #78 from DUNE/feature_prompt_bt
e9c801c 
Backtracking for prompt hits
@liviocali
Update Light MC event generator for new trigger logic. Check configs …
ce4f1ed 
…in yaml to change back
add yamls for proto_nd c+l matching
d86d389
update charge2light
ac753fc
working version of cl matching + matching window change
d35071f
Renaming methods in proto_nd_flow/resource/geometry.py which specify …
0df6661 
…coordinates e.g. pixel_xy, anode_z, and get_z_coordinate.
Updating coordinate names within proto_nd_flow/resources/geometry.py …
1974342 
…_load_charge_geometry method.
Updating drift coordinate to x (from z) in in_fid, regions, and _crea…
f631ed5 
…te_regions methods of proto_nd_flow/resources/geometry.py.
Adding up-to-date 2x2 geometry yamls to proto_nd_flow data directory.
cf30ca1
Updating description in geometry.py to reflect x/z coordinate switch.
403781b
Updating geometry.py to save accurate drift regions as an attribute t…
5893521 
…o geometry_info flow dataset in proto_nd_flow.
Updating geometry.pin_fid() method in proto_nd_flow.
6b70fc2
Updating in_fid() method in geometry.py in proto_nd_flow based on val…
526cf1c 
…idation tests of method.
@ronandoherty1
Remove large initialised arrays
e6321e0
Updating description and use of drift_dir attribute calculated in pro…
47c1e62 
…to_nd_flow Geometry module.
Updating Geometry resource in proto_nd_flow to include lar_detector_b…
39898c8 
…ounds, module_RO_bounds, max_drift_distance, and cathode_thickness attrs and remove drift_regions attr.
Adding beam_direction and drift_direction attrs, updating in_fid() me…
9a48d08 
…thod in proto_nd_flow Geometry module.
Changing units in proto_nd_flow Geometry module attributes and datase…
15ca88b 
…ts from [mm] to [cm].
Fixing drift region definition bug in proto_nd_flow Geometry module i…
bc8699d 
…n_fid() method.
@mjkramer
Make run_data.py support .hdf5 as well as .h5
cb410c7
Removing print statements from proto_nd_flow Geometry module and addi…
2105125 
…ng Geometry module testing infrastructure.
@YifanC
Merge pull request #79 from DUNE/feature_geometry
bd0d1c0 
update the geometry script to match with the module0 one
Add io_group and tile_id to calib_hits_dtype and calib_prompt_hits da…
8e59ff7 
…taset.
@krwood
Merge pull request #87 from ronandoherty1/feature_optimise
76b410e 
Remove large initialised arrays
Changing new saved field in calib_*_hits dsets from tile_id to io_cha…
ea5f974 
…nnel.
@YifanC
Merge pull request #88 from DUNE/feature/ehinkle_iogroup_tileid_to_hi…
3a03882 
…ts_datasets

Add io_group and io_channel to calib_prompt_hits and calib_final_hits datasets
Karolina Wresilo and others added 12 commits December 15, 2023 09:50
2x2 CL matching
7c45546
Changing variable initialization within _load_charge_geometry() metho…
913fa49 
…d in proto_nd_flow Geometry module.
Creating helper method to set module_RO_bounds attribute in _load_cha…
9393d6d 
…rge_geometry method in proto_nd_flow Geometry module.
@edhinkle
Merge branch 'develop' into feature/ehinkle_geo_resource_charge_coord…
67676c1 
…_fix
Adding io_group requirement to same_channel check in calib_hit_merger.
1913704
Merging with origin/develop.
6a07366
Removing comments in proto_nd_flow Geometry module.
ce49280
Manually merging origin geometry resource charge fix feature branch i…
7674fc9 
…nto remote geometry resource charge fix feature branch.
@edhinkle
Merge pull request #90 from DUNE/feature/ehinkle_require_same_iogroup…
6aeec4f 
…_hit_merging

Feature/ehinkle require same iogroup hit merging
@krwood
Merge pull request #89 from DUNE/feature_triggerlogic
e016841 
Feature triggerlogic
Removing outdated pixel layout file from data/proto_nd_flow.
e68a592
@edhinkle
Merge pull request #86 from DUNE/feature/ehinkle_geo_resource_charge_…
ff584f4 
…coord_fix

Feature/ehinkle geo resource charge coord fix
@diaza diaza requested a review from edhinkle December 20, 2023 00:11
edhinkle
edhinkle approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@edhinkle edhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the changes from develop require a change to a parameter in the proto_nd_flow single module event display to reflect that the positional information in the raw_hits dataset is now in [cm] vs. [mm]. I will make this change after merging the PR.

@edhinkle edhinkle merged commit b7dc95d into feature_module1_reflow Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edhinkle edhinkle edhinkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@diaza @edhinkle @krwood @liviocali @ronandoherty1 @mjkramer @YifanC